Page MenuHomePhabricator

sstwcw (sstwcw)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 11 2022, 2:39 PM (19 w, 26 m)

Recent Activity

Thu, Jun 9

sstwcw added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
Thu, Jun 9, 8:55 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D124749: [clang-format] Handle Verilog preprocessor directives.
  • add kw_ prefix to symbols treated as keywords
  • use lambda instead of breaking
Thu, Jun 9, 8:50 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.
  • add brace
Thu, Jun 9, 8:11 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.
Thu, Jun 9, 7:53 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.

use isVerilog

Thu, Jun 9, 7:38 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.

add MacroBlockBegin

Thu, Jun 9, 7:34 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D126934: [clang-format] NFC Sort names of format token types.

use case-insensitive sorting

Thu, Jun 9, 6:54 PM · Restricted Project, Restricted Project

Thu, Jun 2

sstwcw requested review of D126934: [clang-format] NFC Sort names of format token types.
Thu, Jun 2, 6:00 PM · Restricted Project, Restricted Project
sstwcw updated the diff for D124749: [clang-format] Handle Verilog preprocessor directives.
  • add comment and format
Thu, Jun 2, 2:43 AM · Restricted Project, Restricted Project
sstwcw added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
Thu, Jun 2, 2:40 AM · Restricted Project, Restricted Project

Wed, Jun 1

sstwcw updated the diff for D124748: [clang-format] Fix whitespace counting stuff.
  • add comment
Wed, Jun 1, 7:17 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw requested review of D126845: [clang-format] Handle Verilog numbers and operators.
Wed, Jun 1, 6:48 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D124749: [clang-format] Handle Verilog preprocessor directives.
  • use raw string for regex
  • use default style in test
  • remove parentheses
  • use seek now that skipOver no longer exists
Wed, Jun 1, 6:36 PM · Restricted Project, Restricted Project
sstwcw added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
Wed, Jun 1, 6:35 PM · Restricted Project, Restricted Project

May 15 2022

sstwcw added a comment to D124749: [clang-format] Handle Verilog preprocessor directives.

The two parents of this revision change the same file, so the build bot says patch does not apply. Does that mean I have to submit the parent patches with less context?

May 15 2022, 6:28 AM · Restricted Project, Restricted Project
sstwcw added inline comments to D124749: [clang-format] Handle Verilog preprocessor directives.
May 15 2022, 6:19 AM · Restricted Project, Restricted Project
sstwcw updated the diff for D124749: [clang-format] Handle Verilog preprocessor directives.
  • add tests and remove LINE and FILE special cases
May 15 2022, 6:05 AM · Restricted Project, Restricted Project
sstwcw added a comment to D124748: [clang-format] Fix whitespace counting stuff.

This patch is not NFC. But there would not be change in behavior if the
input is valid C as far as I know.

May 15 2022, 6:00 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D124748: [clang-format] Fix whitespace counting stuff.
  • address review comments
May 15 2022, 5:50 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily.
May 15 2022, 5:47 AM · Restricted Project, Restricted Project, Restricted Project

May 1 2022

sstwcw added a comment to D124749: [clang-format] Handle Verilog preprocessor directives.

This revision depends on D124748, but somehow it doesn't show up when I open the parent revision dialog.

May 1 2022, 8:25 PM · Restricted Project, Restricted Project
sstwcw updated the summary of D124749: [clang-format] Handle Verilog preprocessor directives.
May 1 2022, 8:23 PM · Restricted Project, Restricted Project
sstwcw requested review of D124749: [clang-format] Handle Verilog preprocessor directives.
May 1 2022, 8:04 PM · Restricted Project, Restricted Project
sstwcw requested review of D124748: [clang-format] Fix whitespace counting stuff.
May 1 2022, 8:02 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw committed rG43c146c96d8e: [clang-format] Take out common code for parsing blocks NFC (authored by sstwcw).
[clang-format] Take out common code for parsing blocks NFC
May 1 2022, 1:59 AM · Restricted Project, Restricted Project
sstwcw closed D121757: [clang-format] Take out common code for parsing blocks NFC.
May 1 2022, 1:58 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw abandoned D121756: [clang-format] Clean up code looking for if statements.
May 1 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2022

sstwcw committed rGc261f78d05de: [clang-format] Refactor determineStarAmpUsage NFC (authored by sstwcw).
[clang-format] Refactor determineStarAmpUsage NFC
Apr 24 2022, 3:32 PM · Restricted Project, Restricted Project
sstwcw closed D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Apr 24 2022, 3:32 PM · Restricted Project, Restricted Project, Restricted Project

Apr 13 2022

sstwcw added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 13 2022, 6:12 AM · Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.

abandon alias

Apr 13 2022, 6:06 AM · Restricted Project, Restricted Project

Apr 11 2022

sstwcw added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

Would you have a look at the parent revision namely D121756?

Apr 11 2022, 3:24 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D123450: [clang-format] Parse Verilog if statements.

add comment

Apr 11 2022, 3:22 PM · Restricted Project, Restricted Project
sstwcw added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 11 2022, 3:20 PM · Restricted Project, Restricted Project

Apr 9 2022

sstwcw added inline comments to D123450: [clang-format] Parse Verilog if statements.
Apr 9 2022, 3:55 AM · Restricted Project, Restricted Project
sstwcw added a comment to D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst..

It looks like you forgot to chmod +x.

Apr 9 2022, 3:51 AM · Restricted Project, Restricted Project
sstwcw requested review of D123450: [clang-format] Parse Verilog if statements.
Apr 9 2022, 3:47 AM · Restricted Project, Restricted Project

Apr 5 2022

sstwcw updated the diff for D121757: [clang-format] Take out common code for parsing blocks NFC.
Apr 5 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121757: [clang-format] Take out common code for parsing blocks NFC.
Apr 5 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2022

sstwcw added inline comments to D121756: [clang-format] Clean up code looking for if statements.
Apr 3 2022, 1:56 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121756: [clang-format] Clean up code looking for if statements.
Apr 3 2022, 1:52 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

sstwcw added a comment to D121754: [clang-format] Refactor determineStarAmpUsage NFC.

Maybe it's because I removed the final empty line when I pasted the diff as I thought that LF was a line terminator instead of a line separator. I will try using arc from now on.

Mar 30 2022, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw committed rGf6740fe483e9: [clang-format] Indent import statements in JavaScript. (authored by sstwcw).
[clang-format] Indent import statements in JavaScript.
Mar 30 2022, 4:20 PM · Restricted Project, Restricted Project
sstwcw closed D121906: [clang-format] Indent import statements in JavaScript..
Mar 30 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

sstwcw added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

I ran check-clang after formatting the entire code base with the new version. It turned out it did break some tests. It seems to be because it messed up these comments.

Mar 29 2022, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121757: [clang-format] Take out common code for parsing blocks NFC.
Mar 29 2022, 4:25 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 29 2022, 4:23 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121756: [clang-format] Clean up code looking for if statements.
Mar 29 2022, 4:20 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw abandoned D121753: [clang-format] Use a macro for non-C keywords.
Mar 29 2022, 4:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2022

sstwcw added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

I tried formatting the files in clang-formatted-files.txt. Besides the files in the list that get changed when formatted with the program built from main, none gets changed when I format them with the program built from this patch, whether or not parseSwitch is modified.

Mar 24 2022, 4:35 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121756: [clang-format] Clean up code looking for if statements.

This is how checking for while changes behavior.

Mar 24 2022, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121756: [clang-format] Clean up code looking for if statements.
Mar 24 2022, 4:30 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121756: [clang-format] Clean up code looking for if statements.
Mar 24 2022, 4:24 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121756: [clang-format] Clean up code looking for if statements.
Mar 24 2022, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121757: [clang-format] Take out common code for parsing blocks NFC.
Mar 24 2022, 3:45 PM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

sstwcw added a comment to D121756: [clang-format] Clean up code looking for if statements.

It turned out this patch does change behavior.

Mar 21 2022, 4:29 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121753: [clang-format] Use a macro for non-C keywords.

Allow me another attempt in justifying this patch.

Mar 21 2022, 4:25 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121906: [clang-format] Indent import statements in JavaScript..
Mar 21 2022, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121906: [clang-format] Indent import statements in JavaScript..
Mar 21 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121906: [clang-format] Indent import statements in JavaScript..

remove unnecessary check

Mar 21 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst..
Mar 21 2022, 3:52 PM · Restricted Project, Restricted Project
sstwcw added inline comments to D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 21 2022, 3:25 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the summary of D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 21 2022, 3:21 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 21 2022, 3:20 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw committed rG8c31b68f4876: [clang-format] Use an enum for context types. NFC (authored by sstwcw).
[clang-format] Use an enum for context types. NFC
Mar 21 2022, 2:58 PM · Restricted Project
sstwcw closed D121907: [clang-format] Use an enum for context types. NFC.
Mar 21 2022, 2:58 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

sstwcw added inline comments to D121906: [clang-format] Indent import statements in JavaScript..
Mar 18 2022, 4:58 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween.

By the way, last time I used a breakpoint on spaceRequiredBefore and stepped until return.

Mar 18 2022, 4:43 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw abandoned D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween.
Mar 18 2022, 4:41 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121907: [clang-format] Use an enum for context types. NFC.

So out of interest, what is the reason? my assumption is that you wanted to add more for Verilog and you felt adding the extra bools was the wrong design and its better an an enum

You are right.

Mar 18 2022, 4:39 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw retitled D121907: [clang-format] Use an enum for context types. NFC from [clang-format] Use an enum for context types. to [clang-format] Use an enum for context types. NFC.
Mar 18 2022, 4:21 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121907: [clang-format] Use an enum for context types. NFC.

Remove comment.

Mar 18 2022, 4:20 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121906: [clang-format] Indent import statements in JavaScript..

use isJavascript

Mar 18 2022, 4:12 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 18 2022, 3:59 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw committed rGfee94803f59d: [clang-format] Copy help options to the doc directory. (authored by sstwcw).
[clang-format] Copy help options to the doc directory.
Mar 18 2022, 3:51 AM · Restricted Project
sstwcw closed D121890: [clang-format] Copy help options to the doc directory..
Mar 18 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121754: [clang-format] Refactor determineStarAmpUsage NFC.
Mar 18 2022, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2022

sstwcw added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

For the new stuff I have the option of still adding the function parseIndentedBlock but only using it in new code. Please be more blunt about whether I should close this revision and do it that way. I guess I might have misunderstood you before from how you reacted when I closed the large patch.

Mar 17 2022, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst.
Mar 17 2022, 6:33 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121758: [clang-format] Add support for formatting Verilog code.

Yes. I am surprised that you asked since everyone asked me to break it apart.

Mar 17 2022, 6:27 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121890: [clang-format] Copy help options to the doc directory..

The issue is #54418.

Mar 17 2022, 6:24 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the summary of D121890: [clang-format] Copy help options to the doc directory..
Mar 17 2022, 6:15 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121757: [clang-format] Take out common code for parsing blocks NFC.

This patch is only intended to reduce the number of times the functionality gets implemented separately. Any change in behavior would be unintended. And we also use the parseIndentedBlock in Verilog stuff, so it's not just two places. I will wait for the check-clang result to see what to do.

Mar 17 2022, 5:49 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw abandoned D121758: [clang-format] Add support for formatting Verilog code.
Mar 17 2022, 5:32 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw requested review of D121907: [clang-format] Use an enum for context types. NFC.
Mar 17 2022, 5:28 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw requested review of D121906: [clang-format] Indent import statements in JavaScript..
Mar 17 2022, 5:26 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121890: [clang-format] Copy help options to the doc directory..
Mar 17 2022, 5:15 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121890: [clang-format] Copy help options to the doc directory..

If anyone's wondering why all the lines changed. The --qualifier-alignment is too long so all the descriptions are moved to the right.

Mar 17 2022, 1:53 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121890: [clang-format] Copy help options to the doc directory..
Mar 17 2022, 1:51 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw requested review of D121890: [clang-format] Copy help options to the doc directory..
Mar 17 2022, 1:49 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

sstwcw added inline comments to D121756: [clang-format] Clean up code looking for if statements.
Mar 16 2022, 8:18 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121756: [clang-format] Clean up code looking for if statements.
Mar 16 2022, 8:15 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121753: [clang-format] Use a macro for non-C keywords.
Mar 16 2022, 8:09 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121753: [clang-format] Use a macro for non-C keywords.
Mar 16 2022, 8:01 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween.

Use the name spaceRequiredBetween.

Mar 16 2022, 4:55 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added inline comments to D121757: [clang-format] Take out common code for parsing blocks NFC.
Mar 16 2022, 4:32 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121754: [clang-format] Refactor determineStarAmpUsage NFC.

About the tokens that were only in one function.

Mar 16 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the diff for D121754: [clang-format] Refactor determineStarAmpUsage NFC.

Add some test cases and use a separate function for the common parts.

Mar 16 2022, 3:51 PM · Restricted Project, Restricted Project, Restricted Project
sstwcw added a comment to D121758: [clang-format] Add support for formatting Verilog code.

Somehow the bot can't create a branch when trying to merge this patch. The error is failure to lock. The error persists after restarting the process. Does anyone know why?

Mar 16 2022, 12:40 AM · Restricted Project, Restricted Project, Restricted Project
sstwcw updated the summary of D121753: [clang-format] Use a macro for non-C keywords.
Mar 16 2022, 12:36 AM · Restricted Project, Restricted Project, Restricted Project