For functions that accept an rvalue reference type
parameter, use move to avoid copying the parameter.
These were found when implementing CppCoreGuideline F.18 in
clang-tidy.
Paths
| Differential D142825
[llvm][NFC] Use move instead of copy ClosedPublic Authored by ccotter on Jan 28 2023, 5:57 PM.
Details
Summary For functions that accept an rvalue reference type These were found when implementing CppCoreGuideline F.18 in
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Feb 1 2023, 8:20 AM Comment Actions Yes, locally I get $ ./clang/tools/clang-format/git-clang-format HEAD~ clang-format did not modify any files I think (unless something has broken lately) https://buildkite.com/llvm-project/premerge-checks/builds/133226#0185fb40-6564-4910-a1ac-820fd11c0708 is running clang-format. On other PRs I've submitted over the past few weeks have caught an occasional instance where I forgot to run clang-format locally. The message on this phabricator diff saying "clang-format not found in user’s local PATH; not linting file." is due to my local setup not having arc diff know how to automatically run clang-format before sending up the diff (which I need to fix). Closed by commit rG6e3d12951dd7: [llvm][NFC] Use move instead of copy (authored by ccotter, committed by Michael137). · Explain WhyFeb 1 2023, 9:41 AM This revision was automatically updated to reflect the committed changes. ccotter mentioned this in D141569: [clang-tidy] Implement CppCoreGuideline F.18.Feb 16 2023, 8:26 PM
Revision Contents
Diff 493049 llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
llvm/lib/MC/MCParser/MasmParser.cpp
|
clang-format not found in user’s local PATH; not linting file.