This is an archive of the discontinued LLVM Phabricator instance.

Differential D142576

[BOLT][DWARF] Add logging for split dwarf
ClosedPublic

Authored by ayermolo on Jan 25 2023, 12:17 PM.

Download Raw Diff

Details

Reviewers

rafauler
Amir
maksfb

Commits

rG864133c5f950: [BOLT][DWARF] Add logging for split dwarf

Summary

Added logging when bolt is processing binary with split dwarf.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ayermolo created this revision.Jan 25 2023, 12:17 PM

Herald added a reviewer: rafauler. · View Herald TranscriptJan 25 2023, 12:17 PM

Herald added a reviewer: Amir. · View Herald Transcript

Herald added a reviewer: maksfb. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: treapster, hoy, modimo, wenlei. · View Herald Transcript

ayermolo requested review of this revision.Jan 25 2023, 12:17 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 12:17 PM

Herald added subscribers: llvm-commits, yota9. · View Herald Transcript

Harbormaster completed remote builds in B209956: Diff 492228.Jan 25 2023, 1:09 PM

nits

Harbormaster completed remote builds in B210484: Diff 492923.Jan 27 2023, 3:31 PM

LGTM

This revision is now accepted and ready to land.Jan 27 2023, 3:36 PM

rafauler added inline comments.Jan 27 2023, 3:38 PM

bolt/test/X86/dwarf-test-df-logging.test
13	lowercase p

fixed test

Harbormaster completed remote builds in B210489: Diff 492928.Jan 27 2023, 3:45 PM

Closed by commit rG864133c5f950: [BOLT][DWARF] Add logging for split dwarf (authored by ayermolo). · Explain WhyJan 27 2023, 3:51 PM

This revision was automatically updated to reflect the committed changes.

ayermolo added a commit: rG864133c5f950: [BOLT][DWARF] Add logging for split dwarf.

Revision Contents

Path

Size

bolt/

lib/

Core/

BinaryContext.cpp

2 lines

test/

X86/

dwarf-test-df-logging.test

12 lines

Diff 492936

bolt/lib/Core/BinaryContext.cpp

	Show First 20 Lines • Show All 1,555 Lines • ▼ Show 20 Lines		if (std::optional<uint64_t> DWOId = DwarfUnit->getDWOId()) {
	<< DWOName			<< DWOName
	<< " was not retrieved and won't be updated. Please check "			<< " was not retrieved and won't be updated. Please check "
	"relative path.\n";			"relative path.\n";
	continue;			continue;
	}			}
	DWOCUs[*DWOId] = DWOCU;			DWOCUs[*DWOId] = DWOCU;
	}			}
	}			}
				if (!DWOCUs.empty())
				outs() << "BOLT-INFO: processing split DWARF\n";
	}			}

	void BinaryContext::preprocessDebugInfo() {			void BinaryContext::preprocessDebugInfo() {
	struct CURange {			struct CURange {
	uint64_t LowPC;			uint64_t LowPC;
	uint64_t HighPC;			uint64_t HighPC;
	DWARFUnit *Unit;			DWARFUnit *Unit;

	▲ Show 20 Lines • Show All 813 Lines • Show Last 20 Lines

bolt/test/X86/dwarf-test-df-logging.test

This file was added.

				; Testing that we print out INFO message when binary has split dwarf.

				; RUN: mkdir -p %t
				; RUN: cd %t
				; RUN: llvm-mc -dwarf-version=4 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf4-df-dualcu-main.s \
				; RUN: -split-dwarf-file=main.dwo -o main.o
				; RUN: llvm-mc -dwarf-version=4 -filetype=obj -triple x86_64-unknown-linux %p/Inputs/dwarf4-df-dualcu-helper.s \
				; RUN: -split-dwarf-file=helper.dwo -o helper.o
				; RUN: %clang %cflags -gdwarf-5 -gsplit-dwarf=split main.o helper.o -o main.exe
				; RUN: llvm-bolt main.exe -o main.exe.bolt --update-debug-sections \| FileCheck -check-prefix=BOLT %s

				; BOLT: BOLT-INFO: processing split DWARF
				rafaulerUnsubmitted Not Done Reply Inline Actions lowercase p rafauler: lowercase p