This is an archive of the discontinued LLVM Phabricator instance.

[AMDGCN] Fix device lib test to work with lib64
ClosedPublic

Authored by scchan on Jan 24 2023, 2:17 PM.

Details

Summary

This change fixes an issue introduced by
https://reviews.llvm.org/D140315. A new unit test was added to validate
the search for the device libraries being placed in Clang's resource
directory; however, the test didn't take into account that certain
platforms use lib64 for 64-bit library directory.

Change-Id: I8b2ae01899214aef63f4e593c3a509dbf54582ef

Diff Detail

Event Timeline

scchan created this revision.Jan 24 2023, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 2:17 PM
scchan requested review of this revision.Jan 24 2023, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 2:17 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yaxunl accepted this revision.Jan 24 2023, 2:20 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Jan 24 2023, 2:20 PM
arsenm added a subscriber: arsenm.Jan 24 2023, 2:21 PM

The resource directory should be strictly controlled. why would lib64 ever be used here?

The resource directory should be strictly controlled. why would lib64 ever be used here?

The intention is to eventually move the device libs into the library directory inside clang's resource directory, which its name is affected LLVM_LIBDIR_SUFFIX.

This revision was landed with ongoing or failed builds.Jan 25 2023, 6:56 AM
This revision was automatically updated to reflect the committed changes.

The resource directory should be strictly controlled. why would lib64 ever be used here?

The intention is to eventually move the device libs into the library directory inside clang's resource directory, which its name is affected LLVM_LIBDIR_SUFFIX.

The resource directory is the directory above lib64, there's no reason to put this in something configurable