This is an archive of the discontinued LLVM Phabricator instance.

Differential D142496

[asan] fix two memory leaks in integration tests
ClosedPublic

Authored by aartbik on Jan 24 2023, 11:58 AM.

Details

Reviewers
nicolasvasilache
dcaballe
ftynse
springerm
Commits
rGf6b87c0029f1: [asan] fix two memory leaks in integration tests
Summary

Note that I did not track why this started failing exactly,
which is why I CC Matthias on this fix. But at least we run
asan clean again for the whole suite after this change.

Diff Detail

Event Timeline

aartbik created this revision.Jan 24 2023, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 11:58 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 22 others. · View Herald Transcript
aartbik requested review of this revision.Jan 24 2023, 11:58 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJan 24 2023, 11:58 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ftynse accepted this revision.Jan 24 2023, 11:59 AM
This revision is now accepted and ready to land.Jan 24 2023, 11:59 AM
aartbik added a reviewer: springerm.Jan 24 2023, 11:59 AM
This revision was landed with ongoing or failed builds.Jan 24 2023, 12:35 PM
Closed by commit rGf6b87c0029f1: [asan] fix two memory leaks in integration tests (authored by aartbik). · Explain Why
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rGf6b87c0029f1: [asan] fix two memory leaks in integration tests.
Harbormaster completed remote builds in B209718: Diff 491867.Jan 24 2023, 1:17 PM
dcaballe added a comment.Jan 25 2023, 10:40 AM

Ouch... Thanks, Aart!

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
Memref/
2 lines
Vector/
CPU/
2 lines

Diff 491872

mlir/test/Integration/Dialect/Memref/cast-runtime-verification.mlir

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Linesfunc.func @main() {
func.call @cast_to_static_strides(%4) func.call @cast_to_static_strides(%4)
: (memref<?xf32, strided<[?], offset: ?>>) : (memref<?xf32, strided<[?], offset: ?>>)
-> (memref<?xf32, strided<[9], offset: 5>>) -> (memref<?xf32, strided<[9], offset: 5>>)
// A last cast that actually succeeds. // A last cast that actually succeeds.
// CHECK-NOT: ERROR: Runtime op verification failed // CHECK-NOT: ERROR: Runtime op verification failed
func.call @valid_cast(%3) : (memref<*xf32>) -> (memref<?xf32>) func.call @valid_cast(%3) : (memref<*xf32>) -> (memref<?xf32>)
memref.dealloc %alloc : memref<5xf32>
return return
} }

mlir/test/Integration/Dialect/Vector/CPU/test-transfer-write.mlir

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines scf.for %i = %c0 to %c4 step %c1 {
} }
} }
call @transfer_write_inbounds_3d(%A1) : (memref<4x4x4xf32>) -> () call @transfer_write_inbounds_3d(%A1) : (memref<4x4x4xf32>) -> ()
%f = arith.constant 0.0: f32 %f = arith.constant 0.0: f32
%r = vector.transfer_read %A1[%c0, %c0, %c0], %f %r = vector.transfer_read %A1[%c0, %c0, %c0], %f
: memref<4x4x4xf32>, vector<4x4x4xf32> : memref<4x4x4xf32>, vector<4x4x4xf32>
vector.print %r : vector<4x4x4xf32> vector.print %r : vector<4x4x4xf32>
memref.dealloc %A1 : memref<4x4x4xf32>
return return
} }
// CHECK: ( 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK: ( 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK: ( 0, 0, 0, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK: ( 0, 0, 0, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK: ( 0, 0, 0, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 16, 16, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK: ( 0, 0, 0, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 16, 16, 16, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 0 ) // CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 17, 0 )
// CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13 ) // CHECK: ( 0, 0, 0, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 17, 17, 17, 17, 17, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13 )
// 3D case. // 3D case.
// CHECK: ( ( ( 1, 5, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 2, 6, 0, 0 ) ), ( ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ) ), // CHECK: ( ( ( 1, 5, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 2, 6, 0, 0 ) ), ( ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ) ),
// CHECK-SAME: ( ( 3, 7, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 4, 8, 0, 0 ) ), ( ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ) ) ) // CHECK-SAME: ( ( 3, 7, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 4, 8, 0, 0 ) ), ( ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ), ( 0, 0, 0, 0 ) ) )