This is an archive of the discontinued LLVM Phabricator instance.

[extract_symbols.py] Filter out more symbols for MSVC
ClosedPublic

Authored by glandium on Jan 23 2023, 11:35 PM.

Diff Detail

Event Timeline

glandium created this revision.Jan 23 2023, 11:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 11:35 PM
glandium requested review of this revision.Jan 23 2023, 11:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 11:35 PM
glandium edited the summary of this revision. (Show Details)
glandium planned changes to this revision.Jan 24 2023, 1:59 PM
glandium added inline comments.
llvm/utils/extract_symbols.py
171

Actually... they are, and they do :(

glandium updated this revision to Diff 491987.Jan 24 2023, 7:47 PM

Switched to skipping X86GenMnemonicTables functions instead of private methods.

john.brawn added inline comments.Jan 25 2023, 7:24 AM
llvm/utils/extract_symbols.py
146

I think we can also discard __ymm symbols here (from looking at llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp).

171

Could you add something to the comment here saying why discarding these symbols is a valid thing to do?

glandium updated this revision to Diff 492249.Jan 25 2023, 1:52 PM

Updated per feedback.

glandium edited the summary of this revision. (Show Details)Jan 25 2023, 1:52 PM
This revision is now accepted and ready to land.Jan 26 2023, 8:29 AM
This revision was automatically updated to reflect the committed changes.