Page MenuHomePhabricator

glandium (Mike Hommey)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 7 2017, 12:52 AM (109 w, 1 d)

Recent Activity

Feb 7 2019

glandium added a comment to D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg.

LGTM. Do you want me to commit this for you?

Feb 7 2019, 5:03 PM · Restricted Project, Restricted Project
glandium added a comment to D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg.

@efriedma can you take another look? Ideally, this should be backported to the release_80 branch, so that would need to be landed asap.

Feb 7 2019, 4:53 PM · Restricted Project, Restricted Project

Feb 4 2019

glandium updated the diff for D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg.

Updated EmitAArch64BuiltinExpr per https://reviews.llvm.org/D57636#1383751 and the testcase per https://reviews.llvm.org/D57636#1384348

Feb 4 2019, 7:01 PM · Restricted Project, Restricted Project
glandium added a comment to D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg.

(It should be possible to check that we aren't inserting incorrect truncation/extension operations in the IR.)

Feb 4 2019, 4:29 PM · Restricted Project, Restricted Project

Feb 1 2019

glandium added a comment to D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg.

Opened D57636

Feb 1 2019, 8:00 PM
glandium created D57636: [COFF, ARM64] Fix types for _ReadStatusReg, _WriteStatusReg.
Feb 1 2019, 7:59 PM · Restricted Project, Restricted Project
glandium added a comment to D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg.

Will abandon this patch since I have implementations of these which I will upstream soon.

Just to link up the reviews: these landed in D52838 and D53115. (Thanks @mgrang!)

Feb 1 2019, 2:52 PM

Jan 8 2019

glandium created D56475: Don't require a null terminator when loading objects.
Jan 8 2019, 9:37 PM

Nov 28 2018

glandium added a comment to D54891: [RFC] Checking inline assembly for validity.

I can provide a full log of the 4831 warnings marked -Winline-asm during a Firefox for ARM Android build, if you're interested.

Yes, it would be helpful if you could send me that output (with the latest patch applied).

Nov 28 2018, 11:57 PM

Nov 27 2018

glandium added a comment to D54891: [RFC] Checking inline assembly for validity.

Correction, the mpi_arm.c ones seem to be caught. However, warnings are also being emitted for assembly post substitution. Example:

Nov 27 2018, 6:23 PM

Nov 26 2018

glandium added a comment to D54891: [RFC] Checking inline assembly for validity.

Assuming removing the variadicOpsAreDefs test completely (since I couldn't figure where it came from) still yields something that mostly works, it appears not to catch when the assembly writes to input operands. Examples of real code that had the problem:

Nov 26 2018, 6:18 PM
glandium added inline comments to D54891: [RFC] Checking inline assembly for validity.
Nov 26 2018, 3:11 PM

Aug 28 2018

glandium added inline comments to D47656: Show choices of multiple-choice options in `ld.lld --help` message..
Aug 28 2018, 6:08 AM

Nov 7 2017

glandium updated the diff for D39717: Always use prctl(PR_SET_PTRACER).

Updated wording.

Nov 7 2017, 2:10 PM
glandium created D39717: Always use prctl(PR_SET_PTRACER).
Nov 7 2017, 1:00 AM