This is an archive of the discontinued LLVM Phabricator instance.

Differential D142333

[clang][DebugInfo] Check TemplateArgument::IsDefaulted
ClosedPublic

Authored by Michael137 on Jan 23 2023, 1:32 AM.

Details

Reviewers
dblaikie
aprantl
Commits
rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted
Summary

Since ClassTemplateSpecializationDecls now set the
TemplateArgument::IsDefaulted bit, there's no need
to derive it here.

Diff Detail

Unit TestsFailed

TimeTest
3,880 mslibcxx CI Modules > llvm-libc++-shared-cfg-in.libcxx/algorithms/specialized_algorithms/special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp
400 msx64 debian > Builtins-x86_64-linux.Builtins-x86_64-linux::extendhfsf2_test.c
330 msx64 debian > Builtins-x86_64-linux.Builtins-x86_64-linux::truncdfhf2_test.c
300 msx64 debian > Builtins-x86_64-linux.Builtins-x86_64-linux::truncsfhf2_test.c

Event Timeline

Michael137 created this revision.Jan 23 2023, 1:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 1:32 AM
Michael137 requested review of this revision.Jan 23 2023, 1:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 1:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Michael137 added a parent revision: D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument.Jan 23 2023, 1:34 AM
Michael137 updated this revision to Diff 491257.Jan 23 2023, 1:36 AM
  • Make variable const
Harbormaster completed remote builds in B209295: Diff 491257.Jan 23 2023, 2:24 AM
Michael137 mentioned this in D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument.Jan 25 2023, 11:02 AM
Michael137 added a parent revision: D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness.Jan 26 2023, 7:36 AM
Michael137 removed a parent revision: D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness.
aprantl accepted this revision.Jan 26 2023, 9:37 AM
This revision is now accepted and ready to land.Jan 26 2023, 9:37 AM
This revision was landed with ongoing or failed builds.Jan 26 2023, 6:35 PM
Closed by commit rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted (authored by Michael137). · Explain Why
This revision was automatically updated to reflect the committed changes.
Michael137 added a commit: rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted.

Revision Contents

PathSize
clang/
lib/
CodeGen/
9 lines

Diff 491257

clang/lib/CodeGen/CGDebugInfo.cpp

Show First 20 Lines • Show All 2,004 Lines • ▼ Show 20 LinesCGDebugInfo::CollectTemplateParams(std::optional<TemplateArgs> OArgs,
llvm::DIFile *Unit) { llvm::DIFile *Unit) {
if (!OArgs) if (!OArgs)
return llvm::DINodeArray(); return llvm::DINodeArray();
TemplateArgs &Args = *OArgs; TemplateArgs &Args = *OArgs;
SmallVector<llvm::Metadata *, 16> TemplateParams; SmallVector<llvm::Metadata *, 16> TemplateParams;
for (unsigned i = 0, e = Args.Args.size(); i != e; ++i) { for (unsigned i = 0, e = Args.Args.size(); i != e; ++i) {
const TemplateArgument &TA = Args.Args[i]; const TemplateArgument &TA = Args.Args[i];
StringRef Name; StringRef Name;
bool defaultParameter = false; const bool defaultParameter = TA.getIsDefaulted();
if (Args.TList) { if (Args.TList)
Name = Args.TList->getParam(i)->getName(); Name = Args.TList->getParam(i)->getName();
NamedDecl const *ND = Args.TList->getParam(i);
defaultParameter = clang::isSubstitutedDefaultArgument(
CGM.getContext(), TA, ND, Args.Args, Args.TList->getDepth());
}
switch (TA.getKind()) { switch (TA.getKind()) {
case TemplateArgument::Type: { case TemplateArgument::Type: {
llvm::DIType *TTy = getOrCreateType(TA.getAsType(), Unit); llvm::DIType *TTy = getOrCreateType(TA.getAsType(), Unit);
TemplateParams.push_back(DBuilder.createTemplateTypeParameter( TemplateParams.push_back(DBuilder.createTemplateTypeParameter(
TheCU, Name, TTy, defaultParameter)); TheCU, Name, TTy, defaultParameter));
} break; } break;
case TemplateArgument::Integral: { case TemplateArgument::Integral: {
▲ Show 20 Lines • Show All 3,729 Lines • Show Last 20 Lines