This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names
ClosedPublic

Authored by philnik on Jan 22 2023, 8:12 PM.

Diff Detail

Event Timeline

philnik created this revision.Jan 22 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2023, 8:12 PM
philnik requested review of this revision.Jan 22 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2023, 8:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 1 2023, 9:30 AM
ldionne added inline comments.
libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp
1

It would be nice to run the clang-tidy checks in all the CI jobs that run inside our Docker container.

22–26

Consider sorting alphabetically.

This revision is now accepted and ready to land.Feb 1 2023, 9:30 AM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.