Page MenuHomePhabricator
Differential D142322

[libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names
ClosedPublic
Actions

Authored by philnik on Jan 22 2023, 8:12 PM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project
Commits
rGc8eff9560fc1: [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names

Diff Detail

Event Timeline

philnik created this revision.Jan 22 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2023, 8:12 PM
Herald added subscribers: jdoerfert, krytarowski. · View Herald Transcript
philnik requested review of this revision.Jan 22 2023, 8:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2023, 8:12 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B209268: Diff 491225.Jan 22 2023, 10:21 PM
ldionne accepted this revision.Feb 1 2023, 9:30 AM
ldionne added inline comments.
libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp
1

It would be nice to run the clang-tidy checks in all the CI jobs that run inside our Docker container.

22–26

Consider sorting alphabetically.

This revision is now accepted and ready to land.Feb 1 2023, 9:30 AM
Closed by commit rGc8eff9560fc1: [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names (authored by philnik). · Explain WhyFeb 1 2023, 9:57 AM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.
philnik added a commit: rGc8eff9560fc1: [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names.

Revision Contents
Changeset List

PathSize
libcxx/
include/
6 lines
__memory/
2 lines
2 lines
test/
tools/
clang_tidy_checks/
3 lines
2 lines
18 lines
95 lines

Diff 491225

View Options

libcxx/include/__config

Loading...
View Options

libcxx/include/__memory/shared_ptr.h

Loading...
View Options

libcxx/include/__memory/unique_ptr.h

Loading...
View Options

libcxx/test/tools/clang_tidy_checks/CMakeLists.txt

Loading...
View Options

libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp

Loading...
View Options

libcxx/test/tools/clang_tidy_checks/uglify_attributes.hpp

Loading...
View Options

libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp

Loading...