This is an archive of the discontinued LLVM Phabricator instance.

[mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames
ClosedPublic

Authored by python3kgae on Jan 21 2023, 7:27 PM.

Diff Detail

Event Timeline

python3kgae created this revision.Jan 21 2023, 7:27 PM
python3kgae requested review of this revision.Jan 21 2023, 7:27 PM
kuhar accepted this revision.Jan 23 2023, 8:49 AM
This revision is now accepted and ready to land.Jan 23 2023, 8:49 AM
This revision was landed with ongoing or failed builds.Jan 23 2023, 9:07 AM
This revision was automatically updated to reflect the committed changes.
antiagainst added inline comments.Jan 23 2023, 10:51 AM
mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-uint.mlir
1

This test should actually be added into mlir/test/Dialect/SPIRV/IR/asm-op-interface.mlir?

antiagainst added inline comments.Jan 23 2023, 11:09 AM
mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-uint.mlir
1
python3kgae marked an inline comment as done.Jan 23 2023, 7:00 PM
python3kgae added inline comments.
mlir/test/Conversion/PDLToPDLInterp/pdl-to-pdl-interp-uint.mlir
1

Thanks for fix.