This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Linalg] Fix ignoring nodiscard return value
ClosedPublic

Authored by tblah on Jan 20 2023, 4:28 AM.

Details

Summary

ff94419a287c changed the return value of appendMangledType() to
LogicalResult, which is marked as nodiscard. Ignoring the result
generates a warning when building with clang.

Diff Detail

Event Timeline

tblah created this revision.Jan 20 2023, 4:28 AM
tblah requested review of this revision.Jan 20 2023, 4:28 AM
chelini accepted this revision.Jan 20 2023, 4:30 AM
This revision is now accepted and ready to land.Jan 20 2023, 4:30 AM
nicolasvasilache accepted this revision.Jan 20 2023, 4:32 AM
This revision was landed with ongoing or failed builds.Jan 20 2023, 4:51 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the fix, I landed it in @b0d575310f2ee660dadfdaf1e06bac148a575754 to trigger a round of postsubmits.