This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add LocationAttr declarations to ODS
ClosedPublic

Authored by youngar on Jan 19 2023, 11:10 AM.

Details

Summary

This commit adds location attributes and arrays of locations to OpBase.td. Using LocationAttrs directly in an operation is useful when the location does not correspond 1-1 to an operation or value in the IR. We use this in CIRCT to store the declaration location of result ports of HWModule operations.

Diff Detail

Event Timeline

youngar created this revision.Jan 19 2023, 11:10 AM
youngar requested review of this revision.Jan 19 2023, 11:10 AM
rriddle accepted this revision.Jan 19 2023, 11:12 AM
This revision is now accepted and ready to land.Jan 19 2023, 11:12 AM
youngar edited the summary of this revision. (Show Details)Jan 19 2023, 11:33 AM
youngar updated this revision to Diff 490933.Jan 20 2023, 11:52 AM
youngar updated this revision to Diff 491560.Jan 23 2023, 4:54 PM

My old patch was generated with --no-prefix, which seems to have confused phabricator, and lead to the CI failures.

Herald added a project: Restricted Project. · View Herald Transcript

I'm actually surprised we didn't have this one, thanks, let know if you need help landing.

This revision was automatically updated to reflect the committed changes.