[PowerPC] Fix float materialization patterns.
ClosedPublic
Actions

Authored by stefanp on Jan 19 2023, 7:49 AM.

Details

Reviewers

nemanjai
lei
amyk

Group Reviewers

Restricted Project

Commits

rG2e47aafb02f3: [PowerPC] Fix float materialization patterns.

Summary

Two of the float materialization patterns use the VSSRC regsiter class. This
register class is not available before Power 8. The patterns will stay the same
for Power 8 and up but must use the class F4RC for Power 7 and earlier.

This patch fixes those patterns.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

stefanp created this revision.Jan 19 2023, 7:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 7:49 AM

Herald added subscribers: shchenz, kbarton, hiraditya, qcolombet. · View Herald Transcript

stefanp requested review of this revision.Jan 19 2023, 7:49 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 7:49 AM

Removed one line of the test that was not required.

stefanp added a reviewer: Restricted Project.Jan 19 2023, 8:24 AM

Harbormaster completed remote builds in B208761: Diff 490516.Jan 19 2023, 8:39 AM

LGTM. Thanks for fixing this.

llvm/test/CodeGen/PowerPC/ppc-float-spill.ll
2	I assume that the `-O0` is required in order to trigger spills. If so, perhaps just add a comment here to that effect for anyone looking at this in the future.

This revision is now accepted and ready to land.Jan 20 2023, 5:52 AM

LGTM.

Added a comment to the test case.
Rebased to top of trunk.

This revision was landed with ongoing or failed builds.Feb 13 2023, 7:19 AM

Closed by commit rG2e47aafb02f3: [PowerPC] Fix float materialization patterns. (authored by stefanp). · Explain Why

This revision was automatically updated to reflect the committed changes.

stefanp added a commit: rG2e47aafb02f3: [PowerPC] Fix float materialization patterns..

Harbormaster completed remote builds in B213413: Diff 496954.Feb 13 2023, 7:30 AM