This is an archive of the discontinued LLVM Phabricator instance.

[mlir][vector] Limit vector.mask op to single vector result
ClosedPublic

Authored by springerm on Jan 15 2023, 2:59 AM.

Details

Summary

Multiple vector results require multiple masks and passthru values.

Depends On: D141683

Diff Detail

Event Timeline

springerm created this revision.Jan 15 2023, 2:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Jan 15 2023, 2:59 AM

test plz

We don't have an ops that has multiple vector results. An unregistered op doesn't work here either because it doesn't implement the MaskableOpInterface, so we fail before reaching this check. I would leave this without a test instead of adding a bunch of C++ boilerplate to create a new dummy op.

This revision is now accepted and ready to land.Jan 17 2023, 12:03 AM
dcaballe accepted this revision.Jan 17 2023, 1:57 PM

LGTM. This is preserving existing behavior so it should be good to go. Thanks!