libc++ introduced a handful of internal functions that may or may not be
constexpr, depending on C++ version. For pre-constexpr variants we must declare
device counterparts. Otherwise the code fails to compile on the GPU side.
See https://reviews.llvm.org/D79555
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM. Do we need changes to the test-suite to cover this too? (test-suite being in a separate repo, so it would be a separate patch.)
Comment Actions
test-suite on CUDA bots already covering this and the bots are currently broken. This change should fix them (they appear to work when I run them locally with this patch).
__builtin_logb() results in a libcall to logb() which we do not have on the GPU side, so we have to use CUDA-provided function.