Page MenuHomePhabricator
Differential D141307

Add -f[no-]loop-versioning option
AcceptedPublic
Actions

Authored by Leporacanthicus on Jan 9 2023, 10:27 AM.

Details

Reviewers
awarzynski
sscalpone
tblah
Summary

Add flags for loop-versioning pass enable/disable

Diff Detail

Unit TestsFailed
View All

TimeTest
130 msx64 debian > Flang.Driver::code-gen-rv64.f90
Script: -- : 'RUN: at line 5'; rm -f /var/lib/buildkite-agent/builds/llvm-project/build/tools/flang/test/Driver/Output/code-gen-rv64.f90.tmp.o
50 msx64 debian > Flang.Examples::feature-list-class.f90
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -fc1 -load /var/lib/buildkite-agent/builds/llvm-project/build/lib/flangFeatureList.so -plugin feature-list /var/lib/buildkite-agent/builds/llvm-project/flang/test/Examples/feature-list-class.f90 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/flang/test/Examples/feature-list-class.f90
60 msx64 debian > Flang.Examples::feature-list-functions.f90
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -fc1 -load /var/lib/buildkite-agent/builds/llvm-project/build/lib/flangFeatureList.so -plugin feature-list /var/lib/buildkite-agent/builds/llvm-project/flang/test/Examples/feature-list-functions.f90 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/flang/test/Examples/feature-list-functions.f90

Event Timeline

Leporacanthicus created this revision.Jan 9 2023, 10:27 AM
Herald added a reviewer: awarzynski. · View Herald TranscriptJan 9 2023, 10:27 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Leporacanthicus requested review of this revision.Jan 9 2023, 10:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2023, 10:27 AM
Herald added subscribers: cfe-commits, jdoerfert, MaskRay. · View Herald Transcript
Leporacanthicus added a child revision: D141306: Add loop-versioning pass to improve unit-stride.Jan 9 2023, 10:30 AM
Harbormaster completed remote builds in B206584: Diff 487494.Jan 9 2023, 3:01 PM
Leporacanthicus updated this revision to Diff 488949.Jan 13 2023, 4:48 AM

Rebase

Harbormaster completed remote builds in B207600: Diff 488949.Jan 13 2023, 5:35 AM
Leporacanthicus updated this revision to Diff 498065.Feb 16 2023, 10:13 AM

Rebased and updated help-message

Also using different type of template for the option

Harbormaster completed remote builds in B214190: Diff 498065.Feb 16 2023, 11:41 AM
Leporacanthicus updated this revision to Diff 501881.Thu, Mar 2, 8:22 AM

Update for rebase.

Harbormaster completed remote builds in B216988: Diff 501881.Thu, Mar 2, 9:11 AM
Leporacanthicus retitled this revision from [WIP] Add -f[no-]loop-versioning option to Add -f[no-]loop-versioning option.Fri, Mar 3, 2:39 AM
Leporacanthicus edited the summary of this revision. (Show Details)
tblah added a subscriber: tblah.Mon, Mar 6, 10:06 AM

Please could you add tests for the flag forwarding logic in flang/tests/Driver/frontend-forwarding.f90. For example see https://reviews.llvm.org/rGd0d4b635786d510cd919cadbeb7e5e19983242cf

clang/lib/Driver/ToolChains/Flang.cpp
95

Does GFortran only enable this with -Ofast? I would have thought this would be an -On thing because it doesn't impact precision.

flang/include/flang/Frontend/CodeGenOptions.def
27

nit: comment

Leporacanthicus updated this revision to Diff 503360.Wed, Mar 8, 7:25 AM

Updates based on review comments:

  • Add tests.
  • Enable on -O3

Also changed the name to match gfortran.

Herald added a reviewer: sscalpone. · View Herald TranscriptWed, Mar 8, 7:25 AM
Leporacanthicus marked an inline comment as done.Wed, Mar 8, 7:41 AM
Leporacanthicus added inline comments.
clang/lib/Driver/ToolChains/Flang.cpp
95

No, good point.

flang/include/flang/Frontend/CodeGenOptions.def
27

Darn, missed fixing this.

Harbormaster completed remote builds in B218095: Diff 503360.Wed, Mar 8, 8:02 AM
Leporacanthicus updated this revision to Diff 503459.Wed, Mar 8, 11:25 AM
Leporacanthicus marked an inline comment as done.

Fix copied comment to reflect the new content.

Harbormaster completed remote builds in B218170: Diff 503459.Wed, Mar 8, 1:21 PM
tblah accepted this revision.Thu, Mar 9, 3:28 AM

Looks good to me

This revision is now accepted and ready to land.Thu, Mar 9, 3:28 AM
Leporacanthicus updated this revision to Diff 506125.Fri, Mar 17, 10:09 AM

Rebase and fix conflicts

Harbormaster completed remote builds in B220097: Diff 506125.Fri, Mar 17, 10:50 AM

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Driver/
4 lines
lib/
Driver/
ToolChains/
28 lines
flang/
include/
flang/
Frontend/
1 line
Tools/
13 lines
lib/
Frontend/
4 lines
2 lines
test/
Driver/
4 lines
8 lines
2 lines
54 lines

Diff 506125

View Options

clang/include/clang/Driver/Options.td

Loading...
View Options

clang/lib/Driver/ToolChains/Flang.cpp

Loading...
View Options

flang/include/flang/Frontend/CodeGenOptions.def

Loading...
View Options

flang/include/flang/Tools/CLOptions.inc

Loading...
View Options

flang/lib/Frontend/CompilerInvocation.cpp

Loading...
View Options

flang/lib/Frontend/FrontendActions.cpp

Loading...
View Options

flang/test/Driver/driver-help-hidden.f90

Loading...
View Options

flang/test/Driver/driver-help.f90

Loading...
View Options

flang/test/Driver/frontend-forwarding.f90

Loading...
View Options

flang/test/Driver/version-loops.f90

Loading...