This is an archive of the discontinued LLVM Phabricator instance.

[AssignmentTracking][Docs] Add new metadata to LangRef.rst and link to AssignmentTracking.md
ClosedPublic

Authored by Orlando on Jan 6 2023, 6:12 AM.

Diff Detail

Event Timeline

Orlando created this revision.Jan 6 2023, 6:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 6:12 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
Orlando requested review of this revision.Jan 6 2023, 6:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2023, 6:12 AM
jmorse added a comment.Jan 6 2023, 6:17 AM

Rather than store instructions, "instructions that store", seeing how you're marking some memory intrinsics with DIAssignID too?

Mega-nit: I'd suggest not using contractions in the super-formal LangRef document ("They're" -> "They are").

Orlando updated this revision to Diff 486861.Jan 6 2023, 6:53 AM

Thanks @jmorse

+ "store instructions" -> "instructions that store"
+ "They're" -> "They are"

jryans accepted this revision.Jan 11 2023, 2:56 AM
jryans added a subscriber: jryans.

Seems reasonable to me, thanks for adding this! 🙂

This revision is now accepted and ready to land.Jan 11 2023, 2:56 AM
This revision was landed with ongoing or failed builds.Jan 11 2023, 7:49 AM
This revision was automatically updated to reflect the committed changes.