This is an archive of the discontinued LLVM Phabricator instance.

Differential D141009

llvm-objdump: Fix --build-id documentation string
ClosedPublic

Authored by mcgrathr on Jan 4 2023, 11:41 AM.

Details

Reviewers
phosek
jhenderson
MaskRay
mysterymath
Commits
rG9bb2ec2e23ba: llvm-objdump: Fix --build-id documentation string
Summary

The argument is hex digits, so <dir> doesn't make a lot of sense.

Diff Detail

Unit TestsFailed

TimeTest
330 msx64 debian > Profile-x86_64.Linux::counter_promo_for.c
290 msx64 debian > Profile-x86_64.Linux::counter_promo_while.c

Event Timeline

mcgrathr created this revision.Jan 4 2023, 11:41 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptJan 4 2023, 11:41 AM
Herald added a reviewer: MaskRay. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
mcgrathr requested review of this revision.Jan 4 2023, 11:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 11:41 AM
Herald added subscribers: llvm-commits, StephenFan. · View Herald Transcript
phosek accepted this revision.Jan 4 2023, 11:46 AM

LGTM

This revision is now accepted and ready to land.Jan 4 2023, 11:46 AM
mcgrathr added a reviewer: mysterymath.Jan 4 2023, 11:53 AM
This revision was landed with ongoing or failed builds.Jan 4 2023, 11:55 AM
Closed by commit rG9bb2ec2e23ba: llvm-objdump: Fix --build-id documentation string (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG9bb2ec2e23ba: llvm-objdump: Fix --build-id documentation string.
Harbormaster completed remote builds in B205751: Diff 486355.Jan 4 2023, 12:19 PM

Revision Contents

PathSize
llvm/
tools/
llvm-objdump/
2 lines

Diff 486355

llvm/tools/llvm-objdump/ObjdumpOpts.td

Show All 34 Lines
def arch_name_EQ : Joined<["--"], "arch-name=">, def arch_name_EQ : Joined<["--"], "arch-name=">,
HelpText<"Target arch to disassemble for, " HelpText<"Target arch to disassemble for, "
"see --version for available targets">; "see --version for available targets">;
def archive_headers : Flag<["--"], "archive-headers">, def archive_headers : Flag<["--"], "archive-headers">,
HelpText<"Display archive header information">; HelpText<"Display archive header information">;
defm build_id : defm build_id :
Eq<"build-id", "Build ID to look up. Once found, added as an input file">, Eq<"build-id", "Build ID to look up. Once found, added as an input file">,
MetaVarName<"<dir>">; MetaVarName<"<hex>">;
def : Flag<["-"], "a">, Alias<archive_headers>, def : Flag<["-"], "a">, Alias<archive_headers>,
HelpText<"Alias for --archive-headers">; HelpText<"Alias for --archive-headers">;
def demangle : Flag<["--"], "demangle">, HelpText<"Demangle symbol names">; def demangle : Flag<["--"], "demangle">, HelpText<"Demangle symbol names">;
def : Flag<["-"], "C">, Alias<demangle>, HelpText<"Alias for --demangle">; def : Flag<["-"], "C">, Alias<demangle>, HelpText<"Alias for --demangle">;
defm debug_file_directory : defm debug_file_directory :
▲ Show 20 Lines • Show All 324 Lines • Show Last 20 Lines