Comment is stale now that kDynamic is defined as intmin instead of -1.
Confirmed that implementation in parseDimensionListRanked uses kDynamic.
Paths
| Differential D140994
[NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic ClosedPublic Authored by GleasonK on Jan 4 2023, 8:05 AM.
Details Summary Comment is stale now that kDynamic is defined as intmin instead of -1. Confirmed that implementation in parseDimensionListRanked uses kDynamic.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Jan 4 2023, 8:16 AM This revision was landed with ongoing or failed builds.Jan 4 2023, 9:10 AM Closed by commit rG090904070e25: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic (authored by GleasonK, committed by ftynse). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 486296 mlir/include/mlir/IR/OpImplementation.h
mlir/lib/AsmParser/TypeParser.cpp
|