This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic
ClosedPublic

Authored by GleasonK on Jan 4 2023, 8:05 AM.

Details

Summary

Comment is stale now that kDynamic is defined as intmin instead of -1.

Confirmed that implementation in parseDimensionListRanked uses kDynamic.

Diff Detail

Event Timeline

GleasonK created this revision.Jan 4 2023, 8:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
GleasonK requested review of this revision.Jan 4 2023, 8:05 AM
ftynse accepted this revision.Jan 4 2023, 8:16 AM
This revision is now accepted and ready to land.Jan 4 2023, 8:16 AM

Thanks for review - will need someone with commit access land this change.

This revision was landed with ongoing or failed builds.Jan 4 2023, 9:10 AM
This revision was automatically updated to reflect the committed changes.