[NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic
ClosedPublic
Actions

Authored by GleasonK on Jan 4 2023, 8:05 AM.

Details

Reviewers

mehdi_amini
rriddle
ftynse

Commits

rG090904070e25: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic

Summary

Comment is stale now that kDynamic is defined as intmin instead of -1.

Confirmed that implementation in parseDimensionListRanked uses kDynamic.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

GleasonK created this revision.Jan 4 2023, 8:05 AM

Herald added a reviewer: rriddle. · View Herald TranscriptJan 4 2023, 8:05 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 19 others. · View Herald Transcript

GleasonK requested review of this revision.Jan 4 2023, 8:05 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 8:05 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

ftynse accepted this revision.Jan 4 2023, 8:16 AM

This revision is now accepted and ready to land.Jan 4 2023, 8:16 AM

Thanks for review - will need someone with commit access land this change.

This revision was landed with ongoing or failed builds.Jan 4 2023, 9:10 AM

Closed by commit rG090904070e25: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic (authored by GleasonK, committed by ftynse). · Explain Why

This revision was automatically updated to reflect the committed changes.

ftynse added a commit: rG090904070e25: [NFC] Update parseDimensionList comments for dynamic size from -1 to kDynamic.

Harbormaster completed remote builds in B205707: Diff 486296.Jan 4 2023, 9:26 AM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

OpImplementation.h

5 lines

lib/

AsmParser/

TypeParser.cpp

5 lines

Diff 486315

View Options

mlir/include/mlir/IR/OpImplementation.h