This is an archive of the discontinued LLVM Phabricator instance.

OpenMPOpt: Fix introducing empty nvvm.annotations into module
ClosedPublic

Authored by arsenm on Jan 3 2023, 5:46 AM.

Reviewers

arsenm requested review of this revision.Jan 3 2023, 5:46 AM

LG, Thanks

This revision is now accepted and ready to land.Jan 3 2023, 5:47 AM

Path

Size

llvm/

lib/

Transforms/

IPO/

2 lines

test/

Transforms/

OpenMP/

12 lines

Show First 20 Lines • Show All 5,118 Lines • ▼ Show 20 Lines	PreservedAnalyses OpenMPOptCGSCCPass::run(LazyCallGraph::SCC &C,
if (Changed)		if (Changed)
return PreservedAnalyses::none();		return PreservedAnalyses::none();

return PreservedAnalyses::all();		return PreservedAnalyses::all();
}		}

KernelSet llvm::omp::getDeviceKernels(Module &M) {		KernelSet llvm::omp::getDeviceKernels(Module &M) {
// TODO: Create a more cross-platform way of determining device kernels.		// TODO: Create a more cross-platform way of determining device kernels.
NamedMDNode *MD = M.getOrInsertNamedMetadata("nvvm.annotations");		NamedMDNode *MD = M.getNamedMetadata("nvvm.annotations");
KernelSet Kernels;		KernelSet Kernels;

if (!MD)		if (!MD)
return Kernels;		return Kernels;

for (auto *Op : MD->operands()) {		for (auto *Op : MD->operands()) {
if (Op->getNumOperands() < 2)		if (Op->getNumOperands() < 2)
continue;		continue;
Show All 32 Lines

				; RUN: opt -S -passes=openmp-opt < %s \| FileCheck %s
				; Make sure nnvm.annotations isn't introduced into the module

				; CHECK-NOT: nvvm

				define amdgpu_kernel void @foo() {
				ret void
				}

				!llvm.module.flags = !{!0}

				!0 = !{i32 7, !"openmp", i32 50}