This is an archive of the discontinued LLVM Phabricator instance.

[Docs] TestingGuide.rst: Fix incorrect description
ClosedPublic

Authored by DamonFool on Dec 30 2022, 6:49 AM.

Details

Summary

This patch fixes two incorrect descriptions in TestingGuide.rst.

  1. test/lit.site.cfg --> test/lit.site.cfg.py After https://reviews.llvm.org/D37838 , the test/lit.site.cfg had been added a .py extension. So it should be test/lit.site.cfg.py.
  1. $(LLVM_OBJ_ROOT)/$(BuildMode)/bin --> $(LLVM_OBJ_ROOT)/bin The current build system doesn't create a $(BuildMode) directory any more. So it should be removed.

Diff Detail

Event Timeline

DamonFool created this revision.Dec 30 2022, 6:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2022, 6:49 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
DamonFool requested review of this revision.Dec 30 2022, 6:49 AM
mehdi_amini accepted this revision.Dec 30 2022, 9:22 AM
This revision is now accepted and ready to land.Dec 30 2022, 9:22 AM

Do you have commit access or do you need someone to land this for you?

MaskRay accepted this revision.Dec 30 2022, 10:31 AM

Thank you for refreshing the doc!

(You may remove greetings "Hi all," and "Thanks. Best regards, Jie" from the summary/commit message.)

DamonFool edited the summary of this revision. (Show Details)Dec 30 2022, 4:31 PM

Thanks @mehdi_amini and @MaskRay for your review.

Do you have commit access or do you need someone to land this for you?

I'm new in LLVM, so I don't have commit access.
I need your help to land this patch.

Please use “Jie Fu jiefu@tencent.com” to commit the change.
Thanks.

Thank you for refreshing the doc!

(You may remove greetings "Hi all," and "Thanks. Best regards, Jie" from the summary/commit message.)

Got it and done.
Thanks.

This revision was landed with ongoing or failed builds.Dec 30 2022, 11:31 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added inline comments.Dec 30 2022, 11:31 PM
llvm/docs/TestingGuide.rst
238

i'll move ) after the quote.

Thanks @MaskRay for your help.