This is an archive of the discontinued LLVM Phabricator instance.

Differential D140715

[AAPointerInfo] Remove redundant check
AbandonedPublic

Authored by tianshilei1992 on Dec 27 2022, 6:50 PM.

Details

Reviewers
jdoerfert
sameerds
sstefan1
Summary

The check is unnecessary because when Assumption is assigned, it will break the
loop immediately; otherwise Assumption.first is always false.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Dec 27 2022, 6:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 27 2022, 6:50 PM
Herald added subscribers: ormris, okura, kuter, hiraditya. · View Herald Transcript
tianshilei1992 requested review of this revision.Dec 27 2022, 6:50 PM
Herald added a reviewer: sstefan1. · View Herald TranscriptDec 27 2022, 6:50 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B205040: Diff 485448.Dec 27 2022, 7:39 PM
jdoerfert added inline comments.Dec 28 2022, 12:13 AM
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
1653

This breaks the outer loop.

tianshilei1992 abandoned this revision.Dec 28 2022, 1:22 AM
tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
1653

Oh I'm stupid. My eyes need calibration…

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
2 lines

Diff 485448

llvm/lib/Transforms/IPO/AttributorAttributes.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,643 Lines • ▼ Show 20 Lines if (auto *LoadI = dyn_cast<LoadInst>(Usr)) {
if (!IsValidAssume(*IntrI)) if (!IsValidAssume(*IntrI))
continue; continue;
int Idx = CmpI->getOperandUse(0) == LoadU; int Idx = CmpI->getOperandUse(0) == LoadU;
Assumption = {CmpI->getOperand(Idx), IntrI}; Assumption = {CmpI->getOperand(Idx), IntrI};
break; break;
} }
} }
} }
if (Assumption.first)
break;
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

This breaks the outer loop.

jdoerfert: This breaks the outer loop.
tianshilei1992AuthorUnsubmitted
Done
ReplyInline Actions

Oh I'm stupid. My eyes need calibration…

tianshilei1992: Oh I'm stupid. My eyes need calibration…
} }
// Check if we found an assumption associated with this load. // Check if we found an assumption associated with this load.
if (!Assumption.first || !Assumption.second) if (!Assumption.first || !Assumption.second)
return true; return true;
LLVM_DEBUG(dbgs() << "[AAPointerInfo] Assumption found " LLVM_DEBUG(dbgs() << "[AAPointerInfo] Assumption found "
<< *Assumption.second << ": " << *LoadI << *Assumption.second << ": " << *LoadI
▲ Show 20 Lines • Show All 9,726 Lines • Show Last 20 Lines