This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] refactoring loop emitter into its own files.
ClosedPublic

Authored by Peiming on Dec 27 2022, 10:23 AM.

Diff Detail

Event Timeline

Peiming created this revision.Dec 27 2022, 10:23 AM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Dec 27 2022, 10:23 AM
Peiming updated this revision to Diff 485395.Dec 27 2022, 10:24 AM

small fixes

Peiming added inline comments.Dec 27 2022, 10:28 AM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorLoopEmitter.cpp
743 ↗(On Diff #485395)

I do not know why it is comparing SparseTensorLoopEmitter.cpp against CodegenUtils.cpp. But these function remains untouched.

Peiming updated this revision to Diff 485398.Dec 27 2022, 10:38 AM

revert unintended change.

aartbik added inline comments.Dec 27 2022, 10:48 AM
mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.cpp
10

Is this really needed? Is anything in this file still using loop emitter after the move?

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorLoopEmitter.cpp
1 ↗(On Diff #485398)

Just LoopEmitter now?

Peiming updated this revision to Diff 485403.Dec 27 2022, 11:01 AM

address comments.

Peiming marked an inline comment as done.Dec 27 2022, 11:02 AM
Peiming added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.cpp
10

Yeah, it should be removed.

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorLoopEmitter.cpp
1 ↗(On Diff #485398)

Sure

aartbik accepted this revision.Dec 27 2022, 11:04 AM
This revision is now accepted and ready to land.Dec 27 2022, 11:04 AM
This revision was landed with ongoing or failed builds.Dec 27 2022, 11:12 AM
This revision was automatically updated to reflect the committed changes.
Peiming marked an inline comment as done.