This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Enable IAS in the AMDGPU backend
Needs RevisionPublic

Authored by brad on Dec 24 2022, 10:25 PM.

Details

Reviewers
MaskRay
yaxunl
arsenm
Group Reviewers
Restricted Project
Summary

Enable IAS in the AMDGPU backend.

Diff Detail

Event Timeline

brad created this revision.Dec 24 2022, 10:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 24 2022, 10:25 PM
brad requested review of this revision.Dec 24 2022, 10:25 PM

I didn't realize this was off. Can you add some object output run lines to the inline asm tests? I don't think we have any of those

brad added a comment.Jan 13 2023, 8:04 PM

I didn't realize this was off. Can you add some object output run lines to the inline asm tests? I don't think we have any of those

Sorry I'm not sure what you mean by that. Can you please clarify? Do you want to do that? AMDGPU is one of the quite few with IAS disabled in the backend.

I didn't realize this was off. Can you add some object output run lines to the inline asm tests? I don't think we have any of those

Sorry I'm not sure what you mean by that. Can you please clarify? Do you want to do that? AMDGPU is one of the quite few with IAS disabled in the backend.

I mean this patch has no tests. I assume this would be exercised by using -filetype=obj in a testcase using inline asm

arsenm requested changes to this revision.Jan 27 2023, 8:11 AM

Should add some -filetype=obj runlines to asm tests, e.g. llvm/test/CodeGen/AMDGPU/inline-asm.ll

This revision now requires changes to proceed.Jan 27 2023, 8:11 AM

reverse ping?