In Differential Revision: https://reviews.llvm.org/D140550, I refactored many of the string unit tests which also updated the formatting of the touched files using clang-format. I thought it made sense to apply the formatting to the remainder of the tests in string. If this is not desired, I can delete the PR.
Details
Details
- Reviewers
Mordante bemeryesr ldionne - Group Reviewers
Restricted Project - Commits
- rGa40bada91aed: [libc++] Apply clang formatting to all string unit tests
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Typically we don't want these kind of "format patches". But it looking at the parent patch I think it might be good to make an exception. Since the parent patch is not ready for review yet I mark this patch as needs work. That way it doesn't show up in the review queue. When D140550 is reviewed we can look at this patch. At that time feel free to request a review.
Comment Actions
Would it be possible to either revert this change or do a quick fix forward?
libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg | ||
---|---|---|
2–3 | This is not a valid Python syntax, we're seeing the following failure after this change on our builders: llvm-lit: /b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestingConfig.py:151: fatal: unable to parse config file '/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg', traceback: Traceback (most recent call last): File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 139, in load_from_path exec(compile(data, path, "exec"), cfg_globals, None) File "/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg", line 2 if ^ SyntaxError: invalid syntax |
This is not a valid Python syntax, we're seeing the following failure after this change on our builders: