In D140550#4037134, @ldionne wrote:

Thanks for the patch. It took some time to look at it, so it must have been pretty tedious to write it, but I think it's a good improvement overall.

Given the huge number of changes, I might have made the changes without touching the formatting at all to reduce the diff as much as possible, and then do the formatting changes (or not at all). But anyway, they're here now and I've reviewed it like that, so let's not change it. Just something to consider for the future.

Let's try to get this landed quickly to avoid getting stuck in endless rebase conflict resolutions.

Jan 10 2023, 1:49 AM · Restricted Project, Restricted Project

Jan 9 2023

bemeryesr updated the diff for D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Apply clang formatting

Jan 9 2023, 2:08 AM · Restricted Project, Restricted Project

bemeryesr added a comment to D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

In D132149#4010578, @philnik wrote:

I think you misunderstood what I was asking for regarding the tests. I wanted you to move the refactoring into it's own patch, so that the test changes here would be just a single line per test.

Jan 9 2023, 2:02 AM · Restricted Project, Restricted Project

bemeryesr updated the diff for D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Make this PR a child of D140550 and D140612 which refactor and apply clang formatting to the string unit tests. This PR now simply adds the fancy pointer allocator to the tests.
Remove special casing for C++03 for __ulx struct as it doesn't require a default constructor.

Jan 9 2023, 1:52 AM · Restricted Project, Restricted Project

bemeryesr published D140550: [String] Refactor unit tests to allow easy addition of new allocators for review.

Jan 9 2023, 1:41 AM · Restricted Project, Restricted Project

Dec 23 2022

bemeryesr updated the summary of D140612: [String] Apply clang formatting to all string unit tests.

Dec 23 2022, 12:35 AM · Restricted Project, Restricted Project

bemeryesr requested review of D140612: [String] Apply clang formatting to all string unit tests.

Dec 23 2022, 12:31 AM · Restricted Project, Restricted Project

Dec 21 2022

bemeryesr updated the diff for D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Update clang formatting

Dec 21 2022, 1:28 AM · Restricted Project, Restricted Project

bemeryesr added inline comments to D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Dec 21 2022, 12:56 AM · Restricted Project, Restricted Project

bemeryesr added a comment to D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

In D132149#4009312, @ldionne wrote:

I think this patch has a lot of value. @bemeryesr are you blocked on anything wrt this patch?

Dec 21 2022, 12:50 AM · Restricted Project, Restricted Project

bemeryesr updated the diff for D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Remove static assert for trivial destructibility of pointer.
Make comments a bit clearer.
Remove unit test changes (will be added in separate PR).

Dec 21 2022, 12:49 AM · Restricted Project, Restricted Project

Nov 21 2022

bemeryesr added a comment to D132149: [String] Allow fancy pointer as pointer type of basic_string allocator.

Hi @philnik. When you get a chance, could you please have a look at my PR? I made a few changes as mentioned in my comment a while ago. I also updated all the unit tests to also use a fancy pointer allocator. Thanks!

Nov 21 2022, 12:53 AM · Restricted Project, Restricted Project