This is an archive of the discontinued LLVM Phabricator instance.

Add explicit template instantiation declarations.
ClosedPublic

Authored by tkoeppe on Dec 22 2022, 5:33 PM.

Details

Summary

Explicit instantiations should be declared. Found with -Wundefined-func-template.

Diff Detail

Event Timeline

tkoeppe created this revision.Dec 22 2022, 5:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
tkoeppe requested review of this revision.Dec 22 2022, 5:33 PM
rriddle accepted this revision.Dec 22 2022, 5:41 PM
This revision is now accepted and ready to land.Dec 22 2022, 5:41 PM
tkoeppe updated this revision to Diff 485004.Dec 22 2022, 5:47 PM

Updated diff to one made with -U9999.

Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2022, 5:47 PM

I don't have commit access. I'd welcome if someone could commit this change.

Many thanks!

dblaikie accepted this revision.Dec 23 2022, 12:03 PM

Looks good - maybe include info in the description mentioning that the explicit instantiation declarations match existing explicit instantiation definitions in the .cpp file. (I'll include that when I commit in a minute)