Page MenuHomePhabricator

tkoeppe (Thomas Köppe)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 2:14 PM (6 w, 3 d)

Recent Activity

Mar 9 2019

tkoeppe added a comment to D58998: Replace function template (plus explicit specializations) by non-template overloads..

Could you make sure you've run this change through clang-format before submitting? (Or if you do not have commit rights, I can format/commit it for you)

Mar 9 2019, 5:20 PM · Restricted Project
tkoeppe updated the diff for D58998: Replace function template (plus explicit specializations) by non-template overloads..

Changed function template plus specializations to function overloads.

Mar 9 2019, 2:58 PM · Restricted Project
tkoeppe added a comment to D58998: Replace function template (plus explicit specializations) by non-template overloads..

Ah, another reason to prefer templates might be that templates deduce, and overloads convert. With the template, you can be sure that there aren't any accidental conversions (which would hit the deleted primary template).

Mar 9 2019, 2:37 PM · Restricted Project

Mar 7 2019

tkoeppe added a comment to D58998: Replace function template (plus explicit specializations) by non-template overloads..

Is there any reason this needs to be a template -- can't these just be changed to function overloads, instead of template specializations?

I'll second this - and I'm happy to take ownership (if it's needed) of the decision. This code came in with this specialization approach, and I'm going to guess it wasn't for any particularly nuanced reason & is fine to change to overloads as would be more common here.

Mar 7 2019, 1:35 PM · Restricted Project

Mar 5 2019

tkoeppe added a comment to D58998: Replace function template (plus explicit specializations) by non-template overloads..

Is there any reason this needs to be a template -- can't these just be changed to function overloads, instead of template specializations?

Mar 5 2019, 3:41 PM · Restricted Project
tkoeppe added inline comments to D58998: Replace function template (plus explicit specializations) by non-template overloads..
Mar 5 2019, 2:45 PM · Restricted Project
tkoeppe updated the diff for D58998: Replace function template (plus explicit specializations) by non-template overloads..

Moved comment up to the declaration of the primary template and removed mention of other specializations in different headers.

Mar 5 2019, 2:44 PM · Restricted Project
tkoeppe created D58998: Replace function template (plus explicit specializations) by non-template overloads..
Mar 5 2019, 2:29 PM · Restricted Project