I brought the overview document up to date and added information for
most compilation phases to dump out the reeults of the phase.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
flang/docs/Overview.md | ||
---|---|---|
23 | decorated parse tree |
flang/docs/Overview.md | ||
---|---|---|
23 | Good catch! I'll fix it. |
Thanks for the feedback. You're a prince!
flang/docs/Overview.md | ||
---|---|---|
34 | Another good catch. I'll fix this, too. | |
187–189 | This sentence is not clear. I plan to change it as follows: |
flang/docs/Overview.md | ||
---|---|---|
187–189 | My bad. The name of the executable is flang, but it links against the clang driver library. |
For the information that is being removed, e.g. "do concurrent" or the description of ResolveNames -- is this obsolete or repeated in another document?
Looks Good. Thanks for updating this document. A few comments or questions.
flang/docs/Overview.md | ||
---|---|---|
58–59 | Preprocessing also happens, I guess. Is it worth calling it out? | |
61–63 | Nit: The information will also be used for generating optimization reports, debug information etc. | |
68 | Nit: spelling : -fdebug-dump-provenance | |
154 | We lower to FIR and other MLIR dialects (like Arith, Math, Func, OpenMP, OpenACC). But yes, From a Flang compiler perspective FIR is the backbone. With the HLFIR changes going on, we will lower to that as well. | |
178 | Nit: Not all are optimisations, some are transformations that just create a lower-level representation. | |
182 | Is this a bug that this option does not work with fc1 ? |
flang/docs/Overview.md | ||
---|---|---|
182 | I think the -S option is required for this option and the one below to avoid invoking the linker. |
We will reuse wherever possible. If you meant the -fsave-optimization-record option, then we will support it. In the beginning, there will be only optimisation info from LLVM, but I believe we can support FIR/MLIR optimisation info as well.
This information is repeated in other documents. Still, it would be good to reference them from the overview. I'll add such references.
flang/docs/Overview.md | ||
---|---|---|
58–59 | You're right! I'll add that. | |
61–63 | Good point. I'll add references to those. | |
68 | Good catch. Thanks! | |
92–98 | Yes. Thanks for pointing this out. I'll add that. | |
138–139 | Good points. I'll make some changes. | |
178 | Good point. I'll clarify. | |
182 | I'm not sure if it's a bug or not. | |
182 | Good catch. I'll add "-S". |
decorated parse tree