This is an archive of the discontinued LLVM Phabricator instance.

[runtimes] Pass on COMPILER_RT_BUILD_GWP_ASAN option
AbandonedPublic

Authored by DavidSpickett on Dec 14 2022, 2:58 AM.

Details

Reviewers
phosek
MaskRay
Summary

Currently Arm 32 bit fails to build GWP ASAN, which is fine
because you can disable it with an option.

However this was not being passed to the external project
call.

There are probably more options and functions that could
break this way but this is the one I hit building the llvm
release for Arm 32 bit.

Depends on D139536

Diff Detail

Event Timeline

DavidSpickett created this revision.Dec 14 2022, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 2:58 AM
DavidSpickett requested review of this revision.Dec 14 2022, 2:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 2:58 AM

There is maybe a cleaner way to handle things like this but my approach at the minute is fixing what I stumble across.

And the underlying issue is likely the same as https://github.com/llvm/llvm-project/issues/56900 but I am concentrating on other goals at the moment. Seems logical to pass on options in any case.

MaskRay accepted this revision.Dec 17 2022, 9:17 PM
This revision is now accepted and ready to land.Dec 17 2022, 9:17 PM
phosek requested changes to this revision.Dec 18 2022, 6:33 AM

This is not the right approach, this would override the setting for every target but that's undesirable. The bootstrapping build allows building runtimes for multiple targets, but only some of them might want to set this option. See https://github.com/llvm/llvm-project/blob/ba57d2ad4e9ae39ab824430baece730649758dd5/clang/cmake/caches/Fuchsia-stage2.cmake#L114 for the correct way to set this option.

This revision now requires changes to proceed.Dec 18 2022, 6:33 AM
DavidSpickett abandoned this revision.Jan 19 2023, 5:49 AM