This is an archive of the discontinued LLVM Phabricator instance.

[mlir] LLVM: Convert f8 types to i8 when converting to LLVM types
AbandonedPublic

Authored by ezhulenev on Dec 13 2022, 6:39 PM.

Details

Reviewers
ftynse
dcaballe

Diff Detail

Event Timeline

ezhulenev created this revision.Dec 13 2022, 6:39 PM
Herald added a project: Restricted Project. · View Herald Transcript
ezhulenev requested review of this revision.Dec 13 2022, 6:39 PM
ftynse requested changes to this revision.Dec 13 2022, 10:00 PM

Is this the right thing to do? What happens if we have arith.addf %0, %1 : f8, does it get converted to llvm.fadd i8 that will assert later on translation? In any case this needs a test.

This revision now requires changes to proceed.Dec 13 2022, 10:00 PM
ezhulenev abandoned this revision.Dec 14 2022, 1:27 PM