This is an archive of the discontinued LLVM Phabricator instance.

[mlir][crunner] Add support for invoking std::sort.
ClosedPublic

Authored by bixia on Dec 12 2022, 1:41 PM.

Diff Detail

Event Timeline

bixia created this revision.Dec 12 2022, 1:41 PM
bixia requested review of this revision.Dec 12 2022, 1:41 PM
aartbik accepted this revision.Dec 13 2022, 10:00 AM
aartbik added inline comments.
mlir/lib/ExecutionEngine/CRunnerUtils.cpp
41

this looks like commented out code?
is this documenting something?

This revision is now accepted and ready to land.Dec 13 2022, 10:00 AM
bixia updated this revision to Diff 482543.Dec 13 2022, 10:13 AM
bixia marked an inline comment as done.

Removed comment out code.

bixia added inline comments.Dec 13 2022, 10:36 AM
mlir/lib/ExecutionEngine/CRunnerUtils.cpp
41

This was from my experiment, and only works for more recent c++. Removed the comment.

This revision was automatically updated to reflect the committed changes.