Based on comments from @arsenm.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
60,040 ms | x64 debian > libFuzzer.libFuzzer::minimize_crash.test |
Event Timeline
llvm/docs/LangRef.rst | ||
---|---|---|
2236–2237 | The first sentence isn't grammatically correct. Also should not start out with the word legal | |
2239 | Still not stating what legal means in this context | |
2240 | Grammar? | |
2241 | return types? Also what is the behavior for aggregates? Aggregates containing vectors? Nested aggregates with vectors? | |
2243 | Returnings isn't a word; "return values"? | |
2244–2245 | We can't spec attributes in terms of what clang's behavior is today |
I want to remove the description from LangRef directly since we decided to only support this attribute in X86. WDYT?
llvm/docs/LangRef.rst | ||
---|---|---|
2241 | Good question. I think we have considered such cases. See https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGCall.cpp#L4729-L4740 |
clang/lib/CodeGen/CodeGenFunction.cpp | ||
---|---|---|
502–504 ↗ | (On Diff #484805) | I still think the sentence is ill-formed. But I have tried my best. Welcome for suggestions. |
The first sentence isn't grammatically correct. Also should not start out with the word legal