This is an archive of the discontinued LLVM Phabricator instance.

Differential D139605

[mlir] Tidy double the in comment
ClosedPublic

Authored by seanshpark on Dec 7 2022, 11:21 PM.

Details

Reviewers
jpienaar
rriddle
Commits
rGe21d52a88d07: [mlir] Remove double 'the' in comment (NFC)
Summary

This will tidy double 'the' in the comment for 'getInsertionBlock()'.

Diff Detail

Event Timeline

seanshpark created this revision.Dec 7 2022, 11:21 PM
Herald added a reviewer: rriddle. · View Herald TranscriptDec 7 2022, 11:21 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 20 others. · View Herald Transcript
seanshpark requested review of this revision.Dec 7 2022, 11:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 11:21 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Dec 7 2022, 11:21 PM
This revision is now accepted and ready to land.Dec 7 2022, 11:21 PM
seanshpark removed a reviewer: tonic.Dec 8 2022, 1:52 AM
Harbormaster completed remote builds in B201883: Diff 481157.Dec 8 2022, 7:02 AM
seanshpark added a comment.Dec 8 2022, 5:45 PM

Hope some could land this change :)

jpienaar accepted this revision.Dec 9 2022, 2:37 PM

Will help land.

Closed by commit rGe21d52a88d07: [mlir] Remove double 'the' in comment (NFC) (authored by seanshpark, committed by jpienaar). · Explain WhyDec 9 2022, 2:51 PM
This revision was automatically updated to reflect the committed changes.
jpienaar added a commit: rGe21d52a88d07: [mlir] Remove double 'the' in comment (NFC).

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
2 lines

Diff 481157

mlir/include/mlir/IR/Builders.h

Context not available.
} }
/// Return the block the current insertion point belongs to. Note that the /// Return the block the current insertion point belongs to. Note that the
/// the insertion point is not necessarily the end of the block. /// insertion point is not necessarily the end of the block.
Block *getInsertionBlock() const { return block; } Block *getInsertionBlock() const { return block; }
/// Returns the current insertion point of the builder. /// Returns the current insertion point of the builder.
Context not available.