This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] packs sparse tensor mem sizes using llvm.array instead of memref
AbandonedPublic

Authored by Peiming on Dec 7 2022, 5:01 PM.

Diff Detail

Event Timeline

Peiming created this revision.Dec 7 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Dec 7 2022, 5:01 PM
Peiming updated this revision to Diff 481113.Dec 7 2022, 5:09 PM

update some comments.

Peiming updated this revision to Diff 481116.Dec 7 2022, 5:17 PM

remove redundant comments

wrengr added inline comments.Dec 7 2022, 5:31 PM
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorBuilder.cpp
7–10

As I recall, Aart prefers keeping the blank line between the header comment and the includes.

105

Why not float this out of the loop? Mainly to avoid the linewrapping issues, since without those you can also get rid of the curly braces

bixia added a comment.Dec 8 2022, 7:57 AM

LGTM. Thanks!

Peiming abandoned this revision.Dec 13 2022, 3:15 PM