This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][GlobalISel] Fix legalizing image intrinsics for new types
ClosedPublic

Authored by mbrkusanin on Dec 7 2022, 8:49 AM.

Details

Summary

We no longer need to increase vector size to 16 for intrinsics that use more
than 8 vgprs for addr. There is no image intrinsic that needs more than 12
so all currently existing cases will be covered. Using incorrect size was
causing an error in instruction selection because instructions were updated
to require new types (9x32, 10x32, 11x32, 12x32).

Diff Detail

Event Timeline

mbrkusanin created this revision.Dec 7 2022, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 8:49 AM
mbrkusanin requested review of this revision.Dec 7 2022, 8:49 AM
mbrkusanin edited the summary of this revision. (Show Details)Dec 7 2022, 9:07 AM
arsenm accepted this revision.Dec 7 2022, 9:17 AM
This revision is now accepted and ready to land.Dec 7 2022, 9:17 AM
foad accepted this revision.Dec 7 2022, 9:23 AM

LGTM, thanks.

This revision was landed with ongoing or failed builds.Dec 7 2022, 9:30 AM
This revision was automatically updated to reflect the committed changes.