[mlir][tblgen][docs] Use correct introductionary prefix for Syntax description of attributes and types

[zero9178]

Summary

The doc generator currently has the use of ! as prefix hardcoded, despite being incorrect for Attributes. These start with #.

This patch fixes that little issue by using # for AttrDefs and ! for TypeDefs in Syntax field of the generated Markdown file

mlir/test/mlir-tblgen/gen-dialect-doc.td

 // RUN: mlir-tblgen -gen-dialect-doc -I %S/../../include -dialect=test %s | FileCheck %s
 // RUN: mlir-tblgen -gen-dialect-doc -I %S/../../include -dialect=test_toc %s | FileCheck %s --check-prefix=CHECK_TOC
 
 include "mlir/IR/OpBase.td"
+include "mlir/IR/AttrTypeBase.td"
 include "mlir/Interfaces/SideEffectInterfaces.td"
 
 def Test_Dialect : Dialect {
   let name = "test";
   let summary = "Dialect of ops to test";
   let description = [{
     Dialect without a [TOC] here.
     TOC added by tool.
   }];
   let cppNamespace = "NS";
 }
 def AOp : Op<Test_Dialect, "a", [NoMemoryEffect, SingleBlockImplicitTerminator<"YieldOp">]>;
 
 def TestAttr : DialectAttr<Test_Dialect, CPred<"true">> {
   let summary = "attribute summary";
   let description = "attribute description";
 }
 
 def TestType : DialectType<Test_Dialect, CPred<"true">> {
   let summary = "type summary";
   let description = "type description";
 }
 
+def TestAttrDef : AttrDef<Test_Dialect, "TestAttrDef"> {
+  let mnemonic = "test_attr_def";
+}
+
+def TestAttrDefParams : AttrDef<Test_Dialect, "TestAttrDefParams"> {
+  let mnemonic = "test_attr_def_params";
+  let parameters = (ins "int":$value);
+
+  let assemblyFormat = "`<` $value `>`";
+}
+
+def TestTypeDef : TypeDef<Test_Dialect, "TestTypeDef"> {
+  let mnemonic = "test_type_def";
+}
+
+def TestTypeDefParams : TypeDef<Test_Dialect, "TestTypeDefParams"> {
+  let mnemonic = "test_type_def_params";
+  let parameters = (ins "int":$value);
+
+  let assemblyFormat = "`<` $value `>`";
+}
+
 // CHECK: Dialect without a [TOC] here.
 // CHECK: TOC added by tool.
 // CHECK: [TOC]
 
 // CHECK-NOT: [TOC]
 // CHECK: Traits: SingleBlockImplicitTerminator<YieldOp>
 // CHECK: Interfaces: NoMemoryEffect (MemoryEffectOpInterface)
 // CHECK: Effects: MemoryEffects::Effect{}
 
 // CHECK: ## Attribute constraint definition
 // CHECK: ### attribute summary
 // CHECK: attribute description
 
+// CHECK: TestAttrDefAttr
+// CHECK: Syntax:
+// CHECK: #test.test_attr_def
+
+// CHECK: TestAttrDefParamsAttr
+// CHECK: Syntax:
+// CHECK: #test.test_attr_def_params
+
 // CHECK: ## Type constraint definition
 // CHECK: ### type summary
 // CHECK: type description
 
+// CHECK: TestTypeDefType
+// CHECK: Syntax:
+// CHECK: !test.test_type_def
+
+// CHECK: TestTypeDefParamsType
+// CHECK: Syntax:
+// CHECK: !test.test_type_def_params
 
 def Toc_Dialect : Dialect {
   let name = "test_toc";
   let summary = "Dialect of ops to test";
   let description = [{
     Dialect with
 
     [TOC]

mlir/tools/mlir-tblgen/OpDocGen.cpp

 
 //===----------------------------------------------------------------------===//
 // TypeDef Documentation
 //===----------------------------------------------------------------------===//
 
 static void emitAttrOrTypeDefAssemblyFormat(const AttrOrTypeDef &def,
                                             raw_ostream &os) {
   ArrayRef<AttrOrTypeParameter> parameters = def.getParameters();
+  char prefix = isa<AttrDef>(def) ? '#' : '!';
   if (parameters.empty()) {
-    os << "\nSyntax: `!" << def.getDialect().getName() << "."
+    os << "\nSyntax: `" << prefix << def.getDialect().getName() << "."
        << def.getMnemonic() << "`\n";
     return;
   }
 
-  os << "\nSyntax:\n\n```\n!" << def.getDialect().getName() << "."
-     << def.getMnemonic() << "<\n";
+  os << "\nSyntax:\n\n```\n"
+     << prefix << def.getDialect().getName() << "." << def.getMnemonic() << "<\n";
   for (const auto &it : llvm::enumerate(parameters)) {
     const AttrOrTypeParameter &param = it.value();
     os << "  " << param.getSyntax();
     if (it.index() < (parameters.size() - 1))
       os << ",";
     os << "   # " << param.getName() << "\n";
   }
   os << ">\n```\n";