This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Handle nnan and fast on the call in fpmed3 patterns
ClosedPublic

Authored by bogner on Dec 6 2022, 10:22 PM.

Details

Summary

We were only allowing these med3 patterns if the operands were known to not be NaN, but we should also allow it if the calls to max/min have the nnan or fast flags.

Diff Detail

Event Timeline

bogner created this revision.Dec 6 2022, 10:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 10:22 PM
bogner requested review of this revision.Dec 6 2022, 10:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2022, 10:22 PM
foad accepted this revision.Dec 6 2022, 11:04 PM

LGTM, thanks!

Please use full context for patches (git diff -U999999999 or arc diff).

This revision is now accepted and ready to land.Dec 6 2022, 11:04 PM
This revision was landed with ongoing or failed builds.Dec 6 2022, 11:17 PM
This revision was automatically updated to reflect the committed changes.

Please use full context for patches (git diff -U999999999 or arc diff).

I keep forgetting to do that, sorry!