Page MenuHomePhabricator
Differential D139322

[mlir] Fix -Wstrict-prototypes warnings
ClosedPublic
Actions

Authored by tblah on Dec 5 2022, 5:45 AM.

Details

Reviewers
aartbik
nicolasvasilache
kiranchandramohan
ftynse
Commits
rG5d91f79fced1: [mlir] Fix -Wstrict-prototypes warning
Summary

These warnings prevent compilation using clang with -DLLVM_ENABLE_WERROR=On

Diff Detail

Event Timeline

tblah created this revision.Dec 5 2022, 5:45 AM
Herald added a reviewer: aartbik. · View Herald TranscriptDec 5 2022, 5:45 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, anlunx and 22 others. · View Herald Transcript
tblah requested review of this revision.Dec 5 2022, 5:45 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptDec 5 2022, 5:45 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
tblah retitled this revision from [mlir to [mlir] Fix -Wstrict-prototypes warnings.Dec 5 2022, 5:45 AM
tblah edited the summary of this revision. (Show Details)
tblah added a reviewer: kiranchandramohan.
nicolasvasilache added subscribers: alexbatashev, buddy-compiler, burmako and 13 others.Dec 5 2022, 5:53 AM

commit message seems hosed

tblah added a comment.Dec 5 2022, 6:00 AM
In D139322#3970772, @nicolasvasilache wrote:

commit message seems hosed

Sorry, that should be fixed now

Harbormaster completed remote builds in B201095: Diff 480080.Dec 5 2022, 8:21 AM
aartbik added a comment.Dec 5 2022, 2:31 PM

LGTM for sparse change

tblah added a comment.Dec 12 2022, 3:25 AM

ping @nicolasvasilache

ftynse accepted this revision.Dec 12 2022, 3:51 AM
This revision is now accepted and ready to land.Dec 12 2022, 3:51 AM
Closed by commit rG5d91f79fced1: [mlir] Fix -Wstrict-prototypes warning (authored by tblah). · Explain WhyDec 12 2022, 4:05 AM
This revision was automatically updated to reflect the committed changes.
tblah added a commit: rG5d91f79fced1: [mlir] Fix -Wstrict-prototypes warning.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir-c/
2 lines
4 lines
Dialect/
2 lines
16 lines
2 lines
6 lines
test/
CAPI/
4 lines
14 lines
2 lines
14 lines
2 lines
2 lines
2 lines
tools/
mlir-tblgen/
13 lines

Diff 482069

View Options

mlir/include/mlir-c/BuiltinAttributes.h

Loading...
View Options

mlir/include/mlir-c/BuiltinTypes.h

Loading...
View Options

mlir/include/mlir-c/Dialect/Quant.h

Loading...
View Options

mlir/include/mlir-c/IR.h

Loading...
View Options

mlir/include/mlir-c/RegisterEverything.h

Loading...
View Options

mlir/include/mlir-c/Support.h

Loading...
View Options

mlir/test/CAPI/execution_engine.c

Loading...
View Options

mlir/test/CAPI/ir.c

Loading...
View Options

mlir/test/CAPI/llvm.c

Loading...
View Options

mlir/test/CAPI/pass.c

Loading...
View Options

mlir/test/CAPI/pdl.c

Loading...
View Options

mlir/test/CAPI/quant.c

Loading...
View Options

mlir/test/CAPI/sparse_tensor.c

Loading...
View Options

mlir/tools/mlir-tblgen/PassCAPIGen.cpp

Loading...