This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Fix integer dot prod capabilities
ClosedPublic

Authored by kuhar on Nov 30 2022, 4:45 PM.

Details

Summary

Allow the integer dot product cabailities to be used in SPIR-V <1.6 when
the SPV_KHR_integer_dot_product extension is available.

Diff Detail

Event Timeline

kuhar created this revision.Nov 30 2022, 4:45 PM
kuhar requested review of this revision.Nov 30 2022, 4:45 PM
antiagainst accepted this revision.Nov 30 2022, 8:24 PM

We should add some tests for this, given it can be rewritten during automatically import (and silently broke which is not good). It would require defining ops using these capabilities first though. And then we can use those ops to write tests in test/Dialect/SPIRV/IR/availability.mlir. I'm fine landing this right now and add those tests later once you have defined the ops.

This revision is now accepted and ready to land.Nov 30 2022, 8:24 PM
kuhar added a comment.EditedNov 30 2022, 8:27 PM

It would require defining ops using these capabilities first though. And then we can use those ops to write tests in test/Dialect/SPIRV/IR/availability.mlir. I'm fine landing this right now and add those tests later once you have defined the ops.

Yes, I looked into this but decided to split the changes into two parts and land those tests once the new ops are in place.

This revision was automatically updated to reflect the committed changes.