Page MenuHomePhabricator

[AMDGPU] Use s_cmp instead of s_cmpk
ClosedPublic

Authored by foad on Nov 30 2022, 2:42 AM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Commits
rG3d9e226081cf: [AMDGPU] Use s_cmp instead of s_cmpk
Summary

Don't bother pre-shrinking "s_cmp_lg_u32 reg, 0" to s_cmpk_lg_u32
because 0 is already an inline constant so the s_cmpk form is no
smaller.

This is just for consistency with the surrounding code and to simplify a
downstream patch.

Diff Detail

Event Timeline

foad created this revision.Nov 30 2022, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 2:42 AM
foad requested review of this revision.Nov 30 2022, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2022, 2:42 AM
arsenm accepted this revision.Nov 30 2022, 9:09 AM
This revision is now accepted and ready to land.Nov 30 2022, 9:09 AM
This revision was automatically updated to reflect the committed changes.