Fix this bug.
Details
Details
Diff Detail
Diff Detail
Time | Test | |
---|---|---|
40 ms | x64 debian > LLVM.CodeGen/AMDGPU::assert-wrong-alloca-addrspace.ll Script:
--
: 'RUN: at line 1'; not /var/lib/buildkite-agent/builds/llvm-project/build/bin/llc -march=amdgcn -mcpu=gfx900 -filetype=null /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/AMDGPU/assert-wrong-alloca-addrspace.ll 2>&1 | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck
|
Event Timeline
Comment Actions
Its not just SGPRs we want to disable, right? Its inline and literal operands too. So the commit title is slightly misleading.
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
429 | I think it can be the following, which is more generic. let InsVOP3Base = getIns64<Src0VOP3DPP, Src1VOP3DPP, RegisterOperand<VGPR_32>, 3, 0, HasModifiers, HasModifiers, HasOMod, Src0ModVOP3DPP, Src1ModVOP3DPP, Src2Mod>.ret; |
Comment Actions
Retitle and correct as suggested by Joe.
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
429 | Thanks! It works and looks more logical. |