This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] support affine expression on sparse dimensions (codegen implementation)
ClosedPublic

Authored by Peiming on Nov 16 2022, 5:49 PM.

Diff Detail

Event Timeline

Peiming created this revision.Nov 16 2022, 5:49 PM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Nov 16 2022, 5:49 PM
Peiming updated this revision to Diff 476545.Nov 18 2022, 11:46 AM

fix memory leakage.

aartbik accepted this revision.Nov 22 2022, 2:48 PM
aartbik added inline comments.
mlir/lib/Dialect/SparseTensor/Transforms/CodegenUtils.cpp
345

yeah, good todos!

364

an if

This revision is now accepted and ready to land.Nov 22 2022, 2:48 PM
Peiming updated this revision to Diff 477316.Nov 22 2022, 3:02 PM
Peiming marked an inline comment as done.

address comments.

Peiming updated this revision to Diff 477320.Nov 22 2022, 3:22 PM

add some assertions.

Peiming updated this revision to Diff 477329.Nov 22 2022, 3:42 PM

update comments.