Page MenuHomePhabricator
Differential D138035

Fix clang-tidy util findNextTokenSkippingComments
Needs ReviewPublic
Actions

Authored by mbid on Nov 15 2022, 7:04 AM.

Details

Reviewers
njames93
alexfh
aaron.ballman
LegalizeAdulthood
Summary

The function did not update the Start source location, resulting in an
infinite loop if the first token was a comment token.

Diff Detail

Event Timeline

mbid created this revision.Nov 15 2022, 7:04 AM
Herald added a reviewer: njames93. · View Herald TranscriptNov 15 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: carlosgalvezp. · View Herald Transcript
mbid requested review of this revision.Nov 15 2022, 7:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2022, 7:04 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Eugene.Zelenko added reviewers: alexfh, aaron.ballman, LegalizeAdulthood.Nov 15 2022, 7:23 AM
Harbormaster completed remote builds in B197759: Diff 475464.Nov 15 2022, 7:25 AM

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
utils/
8 lines

Diff 475464

View Options

clang-tools-extra/clang-tidy/utils/LexerUtils.cpp

Loading...