This is an archive of the discontinued LLVM Phabricator instance.

[LegacyPM] remove unset variables in PassManagerBuilder
ClosedPublic

Authored by goncharov on Nov 15 2022, 7:00 AM.

Details

Summary

D137915 stopped setting this variables but NewGVN was still used and caused asan failure

Diff Detail

Event Timeline

goncharov created this revision.Nov 15 2022, 7:00 AM
Herald added a project: Restricted Project. · View Herald Transcript
goncharov requested review of this revision.Nov 15 2022, 7:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2022, 7:00 AM
aeubanks accepted this revision.Nov 15 2022, 8:19 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 15 2022, 8:58 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mehdi_amini added inline comments.
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
237

There is no way to enable NewGVNPass anymore? Is this intended?

aeubanks added inline comments.Nov 15 2022, 10:04 AM
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
237

PassManagerBuilder is deprecated (legacy PM for optimization pipeline is deprecated) and I'm in the process of removing it