[asan] -fsanitize-address-outline-instrumentation -> -asan-max-inline-poisoning-size=0

[rsundahl]

Summary

The clang flag -fsanitize-address-outline-instrumentation should not only pass
-asan-instrumentation-with-call-threshold=0 to the sanitizer, but should also
pass -asan-max-inline-poisoning-size=0. Both flags' cutoff values need to be set
to zero to suppress inlining in favor of making calls into compiler-rt.

[rsundahl]

Removed extraneous blank line.

[vitalybuka]

clang/lib/Driver/SanitizerArgs.cpp

1256

CC @kstoimenov

it's maybe not the best name for flag, but the point of AsanOutlineInstrumentation was to reduce binary size.

for -asan-instrumentation-with-call-threshold=0 sizeof(check+asan_report) > sizeof(outlined_check_report), so it helps with size
for -asan-max-inline-poisoning-size=0: usually sizeof(small store/load) < sizeof(poisoning_callbac). It usually increases the size.

Out internal setup expects the current size saving behavior of this flag.

So to move forward we can do the following instead:

1. Create a new flag for -asan-max-inline-poisoning-size=0, e.g. AsanOutlinePoisoning
2. Create a clone flag for -asan-instrumentation-with-call-threshold=0, e.g. AsanOutlineChecks
3. We switch out build system to the clone
4. Extend (or delete) AsanOutlineInstrumentation as in this patch

1260

For changes like this we need to update llvm-project/clang/test/Driver/fsanitize.c

clang/lib/Driver/SanitizerArgs.cpp

if (AsanInvalidPointerCmp) {
     CmdArgs.push_back("-asan-detect-invalid-pointer-cmp");
   }
 
   if (AsanInvalidPointerSub) {
     CmdArgs.push_back("-mllvm");
     CmdArgs.push_back("-asan-detect-invalid-pointer-sub");
   }
 
   if (AsanOutlineInstrumentation) {
     CmdArgs.push_back("-mllvm");
     CmdArgs.push_back("-asan-instrumentation-with-call-threshold=0");
+    CmdArgs.push_back("-mllvm");
+    CmdArgs.push_back("-asan-max-inline-poisoning-size=0");
   }
 
   // Only pass the option to the frontend if the user requested,
   // otherwise the frontend will just use the codegen default.
   if (AsanDtorKind != llvm::AsanDtorKind::Invalid) {
     CmdArgs.push_back(Args.MakeArgString("-fsanitize-address-destructor=" +
                                          AsanDtorKindToString(AsanDtorKind)));
   }