This is an archive of the discontinued LLVM Phabricator instance.

[libc] Forward LLVM_LIBC options when using a runtimes build
ClosedPublic

Authored by jhuber6 on Nov 14 2022, 1:03 PM.

Details

Summary

The `LLVM_ENABLE_RUNTIMES' mode is commonly used to build runtimes that
depend on an up-to-date version of clang. Currently, libc uses some
internal variables that are not forwarded when building in this mode.
This patch forwards the relevent arguments beginning with LLVM_LIBC to
the build when built this way.

Diff Detail

Event Timeline

jhuber6 created this revision.Nov 14 2022, 1:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 1:03 PM
jhuber6 requested review of this revision.Nov 14 2022, 1:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 14 2022, 1:03 PM

LGTM, but I'd recommend getting review from someone more familiar with the runtimes build.

This revision is now accepted and ready to land.Nov 14 2022, 2:15 PM
This revision was landed with ongoing or failed builds.Nov 14 2022, 2:24 PM
This revision was automatically updated to reflect the committed changes.