This is an archive of the discontinued LLVM Phabricator instance.

Differential D137852

[OpenMP] [OMPD] Disabling libompd tests
Needs ReviewPublic

Authored by Vigneshbalu on Nov 11 2022, 9:41 AM.

Details

Reviewers
dreachem
ronlieb
RaviNarayanaswamy
protze.joachim
jdoerfert
Summary

Disabling libompd tests as they are failing differently in differently llvm-bot

Diff Detail

Event Timeline

Vigneshbalu created this revision.Nov 11 2022, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2022, 9:41 AM
Herald added subscribers: guansong, yaxunl. · View Herald Transcript
Vigneshbalu requested review of this revision.Nov 11 2022, 9:41 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptNov 11 2022, 9:41 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B197255: Diff 474792.Nov 11 2022, 9:41 AM
jdoerfert added a comment.Nov 11 2022, 12:33 PM

Can you point at some failures and describe their root cause (if known)?

Vigneshbalu added a comment.Nov 13 2022, 9:25 PM

Two kinds of failures.
One due to cmake which mentioned here : https://github.com/llvm/llvm-project/commit/b5bf908fd7f87d2f0d74f62362a7e08366e926ff
Another one is test case failure and couldnt find the cause since it is not reproducible by ron as well.

I couldn't reproduce both issues in my machine, trying to mimic one of the setup to understand the first one.

jdoerfert added a comment.Nov 14 2022, 8:35 AM
In D137852#3924016, @Vigneshbalu wrote:

Two kinds of failures.
One due to cmake which mentioned here : https://github.com/llvm/llvm-project/commit/b5bf908fd7f87d2f0d74f62362a7e08366e926ff
Another one is test case failure and couldnt find the cause since it is not reproducible by ron as well.

I couldn't reproduce both issues in my machine, trying to mimic one of the setup to understand the first one.

Can you then at least describe the failures in the commit message. Add links, etc. When someone goes back in 4 months it would be impossible to understand what was going on.

Vigneshbalu added a comment.Nov 21 2022, 8:38 PM

We can abandon this as i am trying to fix the issue on https://reviews.llvm.org/D138411

Revision Contents

PathSize
openmp/
libompd/
6 lines

Diff 474792

openmp/libompd/CMakeLists.txt

Show All 10 Lines
find_package (Python3 COMPONENTS Interpreter Development) find_package (Python3 COMPONENTS Interpreter Development)
option(LIBOMP_OMPD_GDB_SUPPORT "Build gdb-plugin code that enables OMPD support in GDB." ${Python3_FOUND}) option(LIBOMP_OMPD_GDB_SUPPORT "Build gdb-plugin code that enables OMPD support in GDB." ${Python3_FOUND})
if(LIBOMP_OMPD_SUPPORT) if(LIBOMP_OMPD_SUPPORT)
set(OMPD_INCLUDE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/src/) set(OMPD_INCLUDE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/src/)
add_subdirectory(src) add_subdirectory(src)
if(LIBOMP_OMPD_GDB_SUPPORT) if(LIBOMP_OMPD_GDB_SUPPORT)
add_subdirectory(gdb-plugin) add_subdirectory(gdb-plugin)
#Different issues are seen from different llvm-bot
#Disabling now, can be enabled by using LIBOMP_OMPD_GDB_TEST_SUPPORT while configuring
if(LIBOMP_OMPD_GDB_TEST_SUPPORT)
add_subdirectory(test) add_subdirectory(test)
endif() endif()
endif() endif()
endif()