This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Macros to clean up StridedMemRefType in the SparseTensorRuntime
ClosedPublic

Authored by wrengr on Nov 9 2022, 1:05 PM.

Details

Summary

In particular, this silences warnings from [-Wsign-compare].

Depends On D137681

Diff Detail

Event Timeline

wrengr created this revision.Nov 9 2022, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 9 2022, 1:05 PM
wrengr requested review of this revision.Nov 9 2022, 1:05 PM
aartbik accepted this revision.Nov 9 2022, 1:25 PM
aartbik added inline comments.
mlir/lib/ExecutionEngine/SparseTensorRuntime.cpp
229

can you spell out it'll to it will
(just since quotations are used a lot here for marking)

235

Just remove the "Hopefully...."
(we should either measure, or just the compiler to inline, and I am pretty confident on that ;-)

This revision is now accepted and ready to land.Nov 9 2022, 1:25 PM
wrengr marked 2 inline comments as done.Nov 9 2022, 1:35 PM
wrengr updated this revision to Diff 474341.Nov 9 2022, 1:36 PM

addressing nits